Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing icons for sound and network #416

Open
duck7000 opened this issue Dec 20, 2023 · 5 comments · May be fixed by #467
Open

missing icons for sound and network #416

duck7000 opened this issue Dec 20, 2023 · 5 comments · May be fixed by #467

Comments

@duck7000
Copy link

duck7000 commented Dec 20, 2023

After installing elementary xfce icons (or git version, no difference) i noticed that the sound icon is missing.
This is in al variants
Screenshot at 2023-12-20 21-06-23

in elementary xfce and elementary xfce darkest the network icon is missing
Screenshot at 2023-12-20 21-09-05

This is tested on Manjaro Mate and endeavourOS Mate

Edit: i checked with those icons but with a different theme and the icons are there! but they are almost the same color as the background, so on a black panel bar it is hardly noticed. On a light panel bar it is fine but not a black one like with the matcha theme

@ignaciop
Copy link

Try selecting "elementary Xfce dark" in System Settings -> Appearance -> Icons.

In think elementary Xfce darkest is deprecated in 0.18

@duck7000
Copy link
Author

Yes i know darkest is deprecated, in the other versions it still don't work right

I want to use the dark version, but in the dark version the sound icon is the wrong color with a black panel bar

On my other machine i have manjaro xfce with both elementary-icons (dependency of xfce) and elementary-xfce-icons installed and the sound icon is working fine so it may have something to do with elementary-icons installed or not

@ignaciop
Copy link

ignaciop commented Dec 21, 2023

I downloaded directly v0.18 and unzipped in /usr/share/icons (Debian). Hope it helps!

@duck7000
Copy link
Author

@ignaciop Installed it, no change unfortunately

@newhoa
Copy link
Contributor

newhoa commented Jun 23, 2024

Thanks for reporting!

The reason we can't fix this by making the volume icon light is... Say we switch to a light volume icon so it can be seen in dark panels. Now in light windows and menus, that icon is no longer visible. By trying to "fake" symbolic icons with monochrome icons in certain places, it makes them not easy or impossible to see in other places.

Probably the best way to fix this is to get rid of the monochrome status icons and colorize them so they are visible on light and dark backgrounds. We've talked about this before and should probably start moving toward that. The Wifi icon was recently updated to be that way, and hopefully is a good solution for that.

Symbolic icons (like what is used for the Xfce Panel Pulse Audio Plugin) are a solution to this because they will match the font color (light on dark panels, dark on light panels).

MATE developers are not interested in implementing symbolic icons. Here is a solution they suggest, which is forcing symbolic icons in the Gtk Theme gtk.css:

/*mate-volume-control*/
/*A symbolic icon is used here and will be gray without this*/
GvcMixerDialog image{
	-gtk-icon-style: symbolic;
}

Another suggestion might be to use the Xfce panel on the MATE DE.

Anyway, hope this helps even if it isn't a very straightforward solution/answer.

newhoa added a commit to newhoa/elementary-xfce that referenced this issue Jun 26, 2024
Use full color icons for volume. These icons match
the rest of the color theme better and are easier
to see in both light and dark themes.

Remove same-named monochromatic icons from the `panel` folder.
Symbolic icons (which automatically recolorize) are now common
so these monochromatic icons should no longer be needed.
In places where developers have chosen not to use symbolic icons,
we shouldn't force the look. This also solves an issue where
the monochromatic icons were difficult to see with mixed
light and dark themes (especially with per-app
light and dark theme preferences becoming more common).

Symlink `-panel` suffixed icons to the new
colorized icons at 16px, 22px. These still
may be used for ayatana indicators. Not sure
if any sizes other than 22px really needed.

Fixes shimmerproject#416
Address part of shimmerproject#362
newhoa added a commit to newhoa/elementary-xfce that referenced this issue Jun 27, 2024
Use full color icons for volume. These icons match
the rest of the color theme better and are easier
to see in both light and dark themes.

Remove same-named monochromatic icons from the `panel` folder.
Symbolic icons (which automatically recolorize) are now common
so these monochromatic icons should no longer be needed.
In places where developers have chosen not to use symbolic icons,
we shouldn't force the look. This also solves an issue where
the monochromatic icons were difficult to see with mixed
light and dark themes (especially with per-app
light and dark theme preferences becoming more common).

Symlink `-panel` suffixed icons to the new
colorized icons at 16px, 22px. These still
may be used for ayatana indicators. Not sure
if any sizes other than 22px really needed.

Fixes shimmerproject#416
Address part of shimmerproject#362
newhoa added a commit to newhoa/elementary-xfce that referenced this issue Jun 30, 2024
Use full color icons for volume. These icons match
the rest of the color theme better and are easier
to see in both light and dark themes.

Remove same-named monochromatic icons from the `panel` folder.
Symbolic icons (which automatically recolorize) are now common
so these monochromatic icons should no longer be needed.
In places where developers have chosen not to use symbolic icons,
we shouldn't force the look. This also solves an issue where
the monochromatic icons were difficult to see with mixed
light and dark themes (especially with per-app
light and dark theme preferences becoming more common).

Symlink `-panel` suffixed icons to the new
colorized icons at 16px, 22px. These still
may be used for ayatana indicators. Not sure
if any sizes other than 22px really needed.

Fixes shimmerproject#416
Fixes shimmerproject#90
Address part of shimmerproject#362
Addresses part of shimmerproject#346
Newer solution to shimmerproject#180
@newhoa newhoa linked a pull request Jun 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants