Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make release tarballs more user-friendly/useful #312

Closed
ochosi opened this issue Jul 4, 2022 · 3 comments
Closed

Make release tarballs more user-friendly/useful #312

ochosi opened this issue Jul 4, 2022 · 3 comments

Comments

@ochosi
Copy link
Member

ochosi commented Jul 4, 2022

Currently our release tarballs are not very helpful. Downloading them is the same as checking out the git repository in a certain state.

What would be nice if a GitHub action (triggered on each new tag) would generate a useable tarball, i.e. one in which make has already run. I imagine that everything would already be in the right directory structure, ideally even with icon-caches pre-generated so that a user can simply download and untar the archive to their local icon theme directory.
@newhoa thoughts?
@newhoa
Copy link
Contributor

newhoa commented Jul 5, 2022

This would be nice. I recently tried to build it on KDE and installing the dependencies was a bit of a hassle. I did have to install clang (or would gcc have worked?) which is not listed in the dependencies/install instructions.

I don't know how this would affect distro/repo packagers, though, if they have their own build scripts and are expecting the release as it currently is (although I guess a dual-release would work in that situation?). Might be more of a question for them.

@newhoa
Copy link
Contributor

newhoa commented Jul 5, 2022

@ochosi I made an issue about supporting HiDPI (#317). The solution requires moving to an SVG-installed theme which might change how to go about doing the Github action and releases. Either the PNG step would need to be optional or it could be eliminated completely.

Not sure if that's the direction you all would like to go in, but in case it is I wanted to put it out there just in case it changed things here.

@ochosi
Copy link
Member Author

ochosi commented Jul 6, 2022

In theory we could attach a source and a read-for-use tarball.

Adding better hidpi support is definitely something I'd look forward to (even though I don't even have the hardware to test this myself), but let's discuss that in the other issue.

ochosi added a commit that referenced this issue Jul 6, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
cc008f4
ochosi added a commit that referenced this issue Jul 6, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
3d05caa
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
c5de121 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
73f9b4b 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
3c9d779 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
90141e5 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
9fb103c 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
c26cc2c 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
c41202e 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
652fac3 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
55973ed 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
4d7e970 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
466361c 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
2204cb8 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
405ae7d 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
3bda983 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
754c6f0 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Aug 1, 2022
@ochosi
ci: Build a release tarball (Fixes #312)
4ebe8dd 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: build the tarball and keep the archive accessible in
the associated GitHub Action.
ochosi added a commit that referenced this issue Sep 8, 2022
@ochosi
ci: Build a release tarball on PRs (Fixes #312)
c46cd15 
On a pull request: build the tarball and add a comment to the PR with a
link to the resource.
On push to master: run the standard symlink check.
@ochosi ochosi closed this as completed in 09a3e11 Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ochosi @newhoa