Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid valune in mode config field causes NullPointerException during shutdown #16

Open
seyfahni opened this issue Jul 1, 2020 · 1 comment
Labels
config affects the configuration files proxy affects only only bungee / waterfall type:bug Something isn't working

Comments

@seyfahni
Copy link
Owner

seyfahni commented Jul 1, 2020

Description
When using the mode value combined on waterfall it displays this message during startup:

[12:26:53 ERROR] [OnlineTime]: invalid mode: combined

and then displays this exception during shutdown:

[12:27:11 ERROR]: Exception disabling plugin OnlineTime
java.lang.NullPointerException: null
	at mr.minecraft15.onlinetime.bungee.OnlineTimeBungeePlugin.onDisable(OnlineTimeBungeePlugin.java:125) ~[?:?]
	at net.md_5.bungee.BungeeCord.independentThreadStop(BungeeCord.java:474) ~[waterfall-358.jar:git:Waterfall-Bootstrap:1.16-R0.2-SNAPSHOT:9234e50:358]
	at net.md_5.bungee.BungeeCord.access$000(BungeeCord.java:101) ~[waterfall-358.jar:git:Waterfall-Bootstrap:1.16-R0.2-SNAPSHOT:9234e50:358]
	at net.md_5.bungee.BungeeCord$5.run(BungeeCord.java:414) ~[waterfall-358.jar:git:Waterfall-Bootstrap:1.16-R0.2-SNAPSHOT:9234e50:358]

The configuration:

language: 'en' # for available languages see / edit messages.yml
servername: 'this server'
messageformat: '&gray&\[[OnlineTime](dark_aqua)\] %message%' # See https://github.com/Phoenix616/MineDown#syntax
saveinterval: 30 # seconds
storage: 'database' # to use e.g. mysql set to 'database' and configure database.properties
mode: 'combined' # use 'combined' for to enable communication between server and proxy
configversion: 2 # Never manually edit this value! It is used to migrate older configurations to the current version.

How Reproduce

  1. Setup a proxy
  2. Set combined as value for mode
  3. Start up waterfall
  4. Stop waterfall
  5. See the errors

Expected behaviour
As the plugin already detected a failed startup nothing should happen during shutdown or if the plugin can still work with the given configuration by using a fallback it should disable normally.

System information:

  • Proxy: waterfall build 358
  • Plugin version: 2.0.2
@seyfahni seyfahni added type:bug Something isn't working proxy affects only only bungee / waterfall logic affects the background logic config affects the configuration files and removed logic affects the background logic labels Jul 1, 2020
@srnyx
Copy link

srnyx commented Nov 11, 2021

Getting this too: [OnlineTime] invalid mode: combined
Makes plugin unusable if mode is set to combined

Does it not use master and slave anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config affects the configuration files proxy affects only only bungee / waterfall type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants