Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question - Can you filter test files from the coverage report? #14

Open
geoffcorey opened this issue Feb 13, 2019 · 4 comments
Open

Question - Can you filter test files from the coverage report? #14

geoffcorey opened this issue Feb 13, 2019 · 4 comments

Comments

@geoffcorey
Copy link

Reading meteor-mocha https://github.com/serut/meteor-coverage#meteor-ignored-folders-and-files is would have assumed the test files would be excluded from the report however I see your bare-exemple app is still showing the test files in the html report. I tried modifying .coverage.json and see it does not have any affect. Am I missing something? Should I be trying to exclude from the report via istanbul plugin in babel config or .istanbul.yml file instead.

.coverage.json

{
  "exclude": [
    "**/*.test.js",
    "**/*.tests.js"
  ],
  "include": [
    "**/*.js"
  ],
  "remap": {
    "format": ["html", "clover", "cobertura", "json", "json-summary", "lcovonly", "teamcity", "text", "text-summary"]
  }
}
@serut
Copy link
Owner

serut commented Feb 13, 2019

This usecase has not been retested since the babel integration so I don't know if that's a bug or not! I will look that asap

@geoffcorey
Copy link
Author

geoffcorey commented Feb 18, 2019 •
edited
Loading

Investigated further and found a few things. The short answer is it does not filter.

The long answer, found other issues:

In my project we keep meteor testing packages our of .meteor/packages and .meteor/versions. We add meteortesting:[email protected] when we run the tests. That package incorrectly installs bad versions of lmieulet:meteor-coverage and meteortesting:mocha-core that do not exclude the results.

If you delete the following lines:

diff --git a/bare-exemple/.meteor/packages b/bare-exemple/.meteor/packages
index 8c50b67..06f4791 100644
--- a/bare-exemple/.meteor/packages
+++ b/bare-exemple/.meteor/packages
@@ -23,5 +23,4 @@ [email protected]                    # Leaner CSS language

 meteortesting:[email protected]               # A package for writing and running your meteor app and package tests with mocha
 johanbrook:publication-collector  # Test a Meteor publication by collecting its output
-lmieulet:[email protected]
 [email protected]
diff --git a/bare-exemple/.meteor/versions b/bare-exemple/.meteor/versions
index 8d83e14..1a25159 100644
--- a/bare-exemple/.meteor/versions
+++ b/bare-exemple/.meteor/versions
@@ -40,13 +40,10 @@ kadira:[email protected]
 [email protected]
 [email protected]
 [email protected]
-lmieulet:[email protected]
 [email protected]
 [email protected]
 [email protected]
-meteortesting:[email protected]
 meteortesting:[email protected]
-meteortesting:[email protected]_3
 [email protected]
 [email protected]
 [email protected]
diff --git a/bare-exemple/package.json b/bare-exemple/package.json
index 7081c55..c38d7fe 100644

And run

rm -fR .coverage
meteor npm run test:coverage

You will see the wrong versions are being installed.

diff --git a/bare-exemple/.meteor/versions b/bare-exemple/.meteor/versions
index 8d83e14..db580df 100644
--- a/bare-exemple/.meteor/versions
+++ b/bare-exemple/.meteor/versions
@@ -40,13 +40,14 @@ kadira:[email protected]
 [email protected]
 [email protected]
 [email protected]
-lmieulet:[email protected]
+lmieulet:[email protected]
 [email protected]
 [email protected]
 [email protected]
-meteortesting:[email protected]
+meteorhacks:[email protected]
+meteortesting:[email protected]
 meteortesting:[email protected]
-meteortesting:[email protected]_3
+meteortesting:[email protected]
 [email protected]
 [email protected]
 [email protected]
diff --git a/bare-exemple/package.json b/bare-exemple/package.json
index 7081c55..c38d7fe 100644
--- a/bare-exemple/package.json
+++ b/bare-exemple/package.json

lmieulet:meteor-coverage ends up as 1.1.4 instead of 3.1.1
meteortesting:browser-tests ends up as 1.0.0 instead of 1.2.0
meteortesting:mocha-core endss up as 1.0.1 instead of 5.2.0_3

The workaround is to explicitly install these versions before running coverage report.

@geoffcorey
Copy link
Author

So I forked this project and stripped from .meteor/versions and .meteor/packages

  • lmieulet:meteor-coverage
  • meteortesting:browser-tests
  • meteortesting:mocha-core
  • meteortesting:mocha

I add meteortesting:mocha via meteor npm run test:add:packages and when I run meteor npm test:coverage you will see the wrong versions are pulled. The difference to my internal application and this example app is those versions is the CSS won't get written for the coverage report. What is the same between the example app and my internal app is writing the LCOV fails.

Fork of the example app is at https://github.com/geoffcorey/meteor-coverage-app-exemple/commit/0f1574c8bcd4a5d17a5987b92be5078a59d16520

I think at the very least the basic instructions for adding code coverage need to be updated and/or meteortesting:mocha should be installing the same versions as your example app. Thoughts?

✘-1 09:25 ~/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple [master ↑·1|✔] $ meteor npm install
npm WARN deprecated [email protected]: Use uuid module instead
npm WARN deprecated [email protected]: This version is no longer maintained. Please upgrade to the latest version.
npm WARN deprecated [email protected]: The major version is no longer supported. Please update to 4.x or newer

> [email protected] install /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/node_modules/puppeteer
> node install.js

Downloading Chromium r624492 - 84.5 Mb [====================] 100% 0.0s
Chromium downloaded to /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/node_modules/puppeteer/.local-chromium/mac-624492
npm notice created a lockfile as package-lock.json. You should commit this file.
added 304 packages from 702 contributors and audited 1043 packages in 27.545s
found 8 moderate severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details
✔ 09:26 ~/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple [master ↑·1|✔] $ meteor npm run test:coverage

> bare-exemple@ test:coverage /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple
> meteor npm run test:add:packages && meteor npm run test:unit:coverage && meteor npm run test:packages:coverage


> bare-exemple@ test:add:packages /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple
> meteor add meteortesting:[email protected]


Changes to your project's package version selections:

lmieulet:meteor-coverage     added, version 1.1.4
meteorhacks:picker           added, version 1.0.3
meteortesting:browser-tests  added, version 1.0.0
meteortesting:mocha          added, version 1.1.2
meteortesting:mocha-core     added, version 1.0.1


meteortesting:mocha: Run Meteor package or app tests with Mocha

> bare-exemple@ test:unit:coverage /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple
> meteor npm run test:add:packages && TEST_BROWSER_DRIVER=puppeteer COVERAGE=1 COVERAGE_VERBOSE=1 COVERAGE_OUT_HTML=1 COVERAGE_OUT_LCOVONLY=1 COVERAGE_APP_FOLDER=$(pwd)/ meteor test --once --driver-package meteortesting:mocha --raw-logs


> bare-exemple@ test:add:packages /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple
> meteor add meteortesting:[email protected]

meteortesting:mocha with version constraint 1.1.1 has already been added.

[[[[[ Tests ]]]]]

=> Started proxy.
=> Started MongoDB.
Coverage active
Reading custom configuration
[Configuration]  { include: [ '**/*.js' ],
  remap:
   { format:
      [ 'html',
        'clover',
        'cobertura',
        'json',
        'json-summary',
        'lcovonly',
        'teamcity',
        'text',
        'text-summary' ] } }
Loading default configuration: exclude.*
Loading default configuration: output
Loading default configuration: remapFormat
Coverage configuration:
- IS_COVERAGE_ACTIVE= true
- IS_COVERAGE_VERBOSE= true
- COVERAGE_APP_FOLDER= /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/
.coverage.json values:
- exclude= { general: [],
  server:
   [ '**/node_modules/**/*.json',
     '**/.!(meteor)*/**',
     '**/packages/!(local-test_?*.js)',
     '**/+([^:]):+([^:])/**',
     '**/@(test|tests|spec|specs)/**',
     '**/?(*.)test?(s).?*',
     '**/?(*.)spec?(s).?*',
     '**/?(*.)app-test?(s).?*',
     '**/?(*.)app-spec?(s).?*' ],
  client:
   [ '**/client/stylesheets/**',
     '**/.npm/package/node_modules/**',
     '**/web.browser/packages/**',
     '**/.?*/**',
     '**/packages/!(local-test_?*.js)',
     '**/+([^:]):+([^:])/**',
     '**/@(test|tests|spec|specs)/**',
     '**/?(*.)test?(s).?*',
     '**/?(*.)spec?(s).?*',
     '**/?(*.)app-test?(s).?*',
     '**/?(*.)app-spec?(s).?*' ] }
- include= [ '**/*.js' ]
- remapFormat= [ 'html',
  'cobertura',
  'clover',
  'json',
  'json-summary',
  'lcovonly',
  'teamcity',
  'text',
  'text-summary' ]
- COVERAGE_EXPORT_FOLDER= ./.coverage

--------------------------------
----- RUNNING SERVER TESTS -----
--------------------------------



  links publications
=> Started your app.

=> App running at: http://localhost:3000/
    links.all
      ✓ sends all links

  links collection
    ✓ insert correctly

  links methods
    ✓ can add a new link

  fake testing the back
    ✓ dumb test
    ✓ should import file


  5 passing (86ms)


--------------------------------
----- RUNNING CLIENT TESTS -----
--------------------------------
HeadlessChrome/73.0.3679.0
[Accepted][include]:  /packages/meteor.js
[ClientSide][Public] file instrumented: /packages/meteor.js
Source map not found ../web.browser/packages/meteor.js.map
[Accepted][include]:  /packages/meteor-base.js
[ClientSide][Public] file instrumented: /packages/meteor-base.js
[Accepted][include]:  /packages/mobile-experience.js
[ClientSide][Public] file instrumented: /packages/mobile-experience.js
[Accepted][include]:  /packages/modules-runtime.js
[ClientSide][Public] file instrumented: /packages/modules-runtime.js
[Accepted][include]:  /packages/modules.js
[ClientSide][Public] file instrumented: /packages/modules.js
[Accepted][include]:  /packages/modern-browsers.js
[ClientSide][Public] file instrumented: /packages/modern-browsers.js
[Accepted][include]:  /packages/babel-compiler.js
[ClientSide][Public] file instrumented: /packages/babel-compiler.js
Source map not found ../web.browser/packages/meteor-base.js.map
Source map not found ../web.browser/packages/mobile-experience.js.map
Source map not found ../web.browser/packages/modern-browsers.js.map
Source map not found ../web.browser/packages/babel-compiler.js.map
Source map not found ../web.browser/packages/modules-runtime.js.map
Source map not found ../web.browser/packages/modules.js.map
[Accepted][include]:  /packages/ecmascript.js
[ClientSide][Public] file instrumented: /packages/ecmascript.js
[Accepted][include]:  /packages/ecmascript-runtime.js
[ClientSide][Public] file instrumented: /packages/ecmascript-runtime.js
[Accepted][include]:  /packages/babel-runtime.js
[ClientSide][Public] file instrumented: /packages/babel-runtime.js
[Accepted][include]:  /packages/promise.js
[ClientSide][Public] file instrumented: /packages/promise.js
[Accepted][include]:  /packages/fetch.js
[ClientSide][Public] file instrumented: /packages/fetch.js
Source map not found ../web.browser/packages/ecmascript-runtime.js.map
Source map not found ../web.browser/packages/ecmascript.js.map
Source map not found ../web.browser/packages/promise.js.map
Source map not found ../web.browser/packages/fetch.js.map
Source map not found ../web.browser/packages/babel-runtime.js.map
[Accepted][include]:  /packages/dynamic-import.js
[ClientSide][Public] file instrumented: /packages/dynamic-import.js
[Accepted][include]:  /packages/es5-shim.js
[ClientSide][Public] file instrumented: /packages/es5-shim.js
[Accepted][include]:  /packages/ecmascript-runtime-client.js
[ClientSide][Public] file instrumented: /packages/ecmascript-runtime-client.js
[Accepted][include]:  /packages/base64.js
[ClientSide][Public] file instrumented: /packages/base64.js
[Accepted][include]:  /packages/ejson.js
[ClientSide][Public] file instrumented: /packages/ejson.js
Source map not found ../web.browser/packages/dynamic-import.js.map
[Accepted][include]:  /packages/diff-sequence.js
[ClientSide][Public] file instrumented: /packages/diff-sequence.js
Source map not found ../web.browser/packages/es5-shim.js.map
registerSourceMap ../web.browser/packages/base64.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/base64/base64.js
Altered source could not be accessed: meteor://💻app/packages/base64/base64.js
Add source map for file ../web.browser/packages/base64.js.map
registerSourceMap ../web.browser/packages/base64.js
registerSourceMap ../web.browser/packages/ejson.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ejson/ejson.js
Altered source could not be accessed: meteor://💻app/packages/ejson/ejson.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ejson/stringify.js
Altered source could not be accessed: meteor://💻app/packages/ejson/stringify.js
Add source map for file ../web.browser/packages/ejson.js.map
registerSourceMap ../web.browser/packages/ejson.js
Source map not found ../web.browser/packages/ecmascript-runtime-client.js.map
[Accepted][include]:  /packages/geojson-utils.js
[ClientSide][Public] file instrumented: /packages/geojson-utils.js
[Accepted][include]:  /packages/id-map.js
[ClientSide][Public] file instrumented: /packages/id-map.js
[Accepted][include]:  /packages/random.js
[ClientSide][Public] file instrumented: /packages/random.js
[Accepted][include]:  /packages/mongo-id.js
[ClientSide][Public] file instrumented: /packages/mongo-id.js
registerSourceMap ../web.browser/packages/diff-sequence.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/diff-sequence/diff.js
Altered source could not be accessed: meteor://💻app/packages/diff-sequence/diff.js
Add source map for file ../web.browser/packages/diff-sequence.js.map
registerSourceMap ../web.browser/packages/diff-sequence.js
[Accepted][include]:  /packages/ordered-dict.js
[ClientSide][Public] file instrumented: /packages/ordered-dict.js
registerSourceMap ../web.browser/packages/id-map.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/id-map/id-map.js
Altered source could not be accessed: meteor://💻app/packages/id-map/id-map.js
Add source map for file ../web.browser/packages/id-map.js.map
registerSourceMap ../web.browser/packages/id-map.js
registerSourceMap ../web.browser/packages/random.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/random/random.js
Altered source could not be accessed: meteor://💻app/packages/random/random.js
Add source map for file ../web.browser/packages/random.js.map
registerSourceMap ../web.browser/packages/random.js
Source map not found ../web.browser/packages/geojson-utils.js.map
registerSourceMap ../web.browser/packages/mongo-id.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/mongo-id/id.js
Altered source could not be accessed: meteor://💻app/packages/mongo-id/id.js
Add source map for file ../web.browser/packages/mongo-id.js.map
registerSourceMap ../web.browser/packages/mongo-id.js
[Accepted][include]:  /packages/tracker.js
[ClientSide][Public] file instrumented: /packages/tracker.js
[Accepted][include]:  /packages/minimongo.js
[ClientSide][Public] file instrumented: /packages/minimongo.js
[Accepted][include]:  /packages/check.js
[ClientSide][Public] file instrumented: /packages/check.js
[Accepted][include]:  /packages/retry.js
[ClientSide][Public] file instrumented: /packages/retry.js
registerSourceMap ../web.browser/packages/ordered-dict.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ordered-dict/ordered_dict.js
Altered source could not be accessed: meteor://💻app/packages/ordered-dict/ordered_dict.js
Add source map for file ../web.browser/packages/ordered-dict.js.map
registerSourceMap ../web.browser/packages/ordered-dict.js
[Accepted][include]:  /packages/callback-hook.js
[ClientSide][Public] file instrumented: /packages/callback-hook.js
registerSourceMap ../web.browser/packages/check.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/check/match.js
Altered source could not be accessed: meteor://💻app/packages/check/match.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/check/isPlainObject.js
Altered source could not be accessed: meteor://💻app/packages/check/isPlainObject.js
Add source map for file ../web.browser/packages/check.js.map
registerSourceMap ../web.browser/packages/check.js
registerSourceMap ../web.browser/packages/tracker.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/tracker/tracker.js
Altered source could not be accessed: meteor://💻app/packages/tracker/tracker.js
Add source map for file ../web.browser/packages/tracker.js.map
registerSourceMap ../web.browser/packages/tracker.js
registerSourceMap ../web.browser/packages/minimongo.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/minimongo/minimongo_client.js
Altered source could not be accessed: meteor://💻app/packages/minimongo/minimongo_client.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/minimongo/common.js
Altered source could not be accessed: meteor://💻app/packages/minimongo/common.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/minimongo/cursor.js
Altered source could not be accessed: meteor://💻app/packages/minimongo/cursor.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/minimongo/local_collection.js
Altered source could not be accessed: meteor://💻app/packages/minimongo/local_collection.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/minimongo/matcher.js
Altered source could not be accessed: meteor://💻app/packages/minimongo/matcher.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/minimongo/minimongo_common.js
Altered source could not be accessed: meteor://💻app/packages/minimongo/minimongo_common.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/minimongo/observe_handle.js
Altered source could not be accessed: meteor://💻app/packages/minimongo/observe_handle.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/minimongo/sorter.js
Altered source could not be accessed: meteor://💻app/packages/minimongo/sorter.js
Add source map for file ../web.browser/packages/minimongo.js.map
registerSourceMap ../web.browser/packages/minimongo.js
registerSourceMap ../web.browser/packages/retry.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/retry/retry.js
Altered source could not be accessed: meteor://💻app/packages/retry/retry.js
Add source map for file ../web.browser/packages/retry.js.map
registerSourceMap ../web.browser/packages/retry.js
[Accepted][include]:  /packages/ddp-common.js
[ClientSide][Public] file instrumented: /packages/ddp-common.js
[Accepted][include]:  /packages/reload.js
[ClientSide][Public] file instrumented: /packages/reload.js
[Accepted][include]:  /packages/socket-stream-client.js
[ClientSide][Public] file instrumented: /packages/socket-stream-client.js
registerSourceMap ../web.browser/packages/callback-hook.js
Add source map for file ../web.browser/packages/callback-hook.js.map
registerSourceMap ../web.browser/packages/callback-hook.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/callback-hook/hook.js
Altered source could not be accessed: meteor://💻app/packages/callback-hook/hook.js
[Accepted][include]:  /packages/ddp-client.js
[ClientSide][Public] file instrumented: /packages/ddp-client.js
[Accepted][include]:  /packages/ddp.js
[ClientSide][Public] file instrumented: /packages/ddp.js
[Accepted][include]:  /packages/ddp-server.js
[ClientSide][Public] file instrumented: /packages/ddp-server.js
registerSourceMap ../web.browser/packages/reload.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/reload/reload.js
Altered source could not be accessed: meteor://💻app/packages/reload/reload.js
Add source map for file ../web.browser/packages/reload.js.map
registerSourceMap ../web.browser/packages/reload.js
registerSourceMap ../web.browser/packages/ddp-common.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ddp-common/namespace.js
Altered source could not be accessed: meteor://💻app/packages/ddp-common/namespace.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ddp-common/heartbeat.js
Altered source could not be accessed: meteor://💻app/packages/ddp-common/heartbeat.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ddp-common/utils.js
Altered source could not be accessed: meteor://💻app/packages/ddp-common/utils.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ddp-common/method_invocation.js
Altered source could not be accessed: meteor://💻app/packages/ddp-common/method_invocation.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ddp-common/random_stream.js
Altered source could not be accessed: meteor://💻app/packages/ddp-common/random_stream.js
Add source map for file ../web.browser/packages/ddp-common.js.map
registerSourceMap ../web.browser/packages/ddp-common.js
registerSourceMap ../web.browser/packages/socket-stream-client.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/socket-stream-client/browser.js
Altered source could not be accessed: meteor://💻app/packages/socket-stream-client/browser.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/socket-stream-client/common.js
Altered source could not be accessed: meteor://💻app/packages/socket-stream-client/common.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/socket-stream-client/sockjs-0.3.4.js
Altered source could not be accessed: meteor://💻app/packages/socket-stream-client/sockjs-0.3.4.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/socket-stream-client/urls.js
Altered source could not be accessed: meteor://💻app/packages/socket-stream-client/urls.js
Add source map for file ../web.browser/packages/socket-stream-client.js.map
registerSourceMap ../web.browser/packages/socket-stream-client.js
registerSourceMap ../web.browser/packages/ddp-client.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ddp-client/client/client.js
Altered source could not be accessed: meteor://💻app/packages/ddp-client/client/client.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ddp-client/client/client_convenience.js
Altered source could not be accessed: meteor://💻app/packages/ddp-client/client/client_convenience.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ddp-client/common/MethodInvoker.js
Altered source could not be accessed: meteor://💻app/packages/ddp-client/common/MethodInvoker.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ddp-client/common/livedata_connection.js
Altered source could not be accessed: meteor://💻app/packages/ddp-client/common/livedata_connection.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/ddp-client/common/namespace.js
Altered source could not be accessed: meteor://💻app/packages/ddp-client/common/namespace.js
Add source map for file ../web.browser/packages/ddp-client.js.map
registerSourceMap ../web.browser/packages/ddp-client.js
[Accepted][include]:  /packages/allow-deny.js
[ClientSide][Public] file instrumented: /packages/allow-deny.js
[Accepted][include]:  /packages/mongo-dev-server.js
[ClientSide][Public] file instrumented: /packages/mongo-dev-server.js
Source map not found ../web.browser/packages/ddp-server.js.map
Source map not found ../web.browser/packages/ddp.js.map
Source map not found ../web.browser/packages/mongo-dev-server.js.map
[Accepted][include]:  /packages/mongo.js
[ClientSide][Public] file instrumented: /packages/mongo.js
[Accepted][include]:  /packages/blaze-html-templates.js
[ClientSide][Public] file instrumented: /packages/blaze-html-templates.js
[Accepted][include]:  /packages/reactive-var.js
[ClientSide][Public] file instrumented: /packages/reactive-var.js
registerSourceMap ../web.browser/packages/allow-deny.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/allow-deny/allow-deny.js
Altered source could not be accessed: meteor://💻app/packages/allow-deny/allow-deny.js
Add source map for file ../web.browser/packages/allow-deny.js.map
registerSourceMap ../web.browser/packages/allow-deny.js
[Accepted][include]:  /packages/standard-minifier-css.js
[ClientSide][Public] file instrumented: /packages/standard-minifier-css.js
[Accepted][include]:  /packages/standard-minifier-js.js
[ClientSide][Public] file instrumented: /packages/standard-minifier-js.js
Source map not found ../web.browser/packages/blaze-html-templates.js.map
Source map not found ../web.browser/packages/reactive-var.js.map
registerSourceMap ../web.browser/packages/mongo.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/mongo/local_collection_driver.js
Altered source could not be accessed: meteor://💻app/packages/mongo/local_collection_driver.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/mongo/collection.js
Altered source could not be accessed: meteor://💻app/packages/mongo/collection.js
Add source map for file ../web.browser/packages/mongo.js.map
registerSourceMap ../web.browser/packages/mongo.js
Source map not found ../web.browser/packages/standard-minifier-js.js.map
Source map not found ../web.browser/packages/standard-minifier-css.js.map
[Accepted][include]:  /packages/shell-server.js
[ClientSide][Public] file instrumented: /packages/shell-server.js
[Accepted][include]:  /packages/underscore.js
[ClientSide][Public] file instrumented: /packages/underscore.js
[Accepted][include]:  /packages/reactive-dict.js
[ClientSide][Public] file instrumented: /packages/reactive-dict.js
[Accepted][include]:  /packages/kadira_flow-router.js
[ClientSide][Public] file instrumented: /packages/kadira_flow-router.js
[Accepted][include]:  /packages/jquery.js
[ClientSide][Public] file instrumented: /packages/jquery.js
[Accepted][include]:  /packages/observe-sequence.js
[ClientSide][Public] file instrumented: /packages/observe-sequence.js
Source map not found ../web.browser/packages/shell-server.js.map
Source map not found ../web.browser/packages/underscore.js.map
Source map not found ../web.browser/packages/kadira_flow-router.js.map
registerSourceMap ../web.browser/packages/reactive-dict.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/reactive-dict/migration.js
Altered source could not be accessed: meteor://💻app/packages/reactive-dict/migration.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/reactive-dict/reactive-dict.js
Altered source could not be accessed: meteor://💻app/packages/reactive-dict/reactive-dict.js
Add source map for file ../web.browser/packages/reactive-dict.js.map
registerSourceMap ../web.browser/packages/reactive-dict.js
[Accepted][include]:  /packages/deps.js
[ClientSide][Public] file instrumented: /packages/deps.js
Source map not found ../web.browser/packages/jquery.js.map
Source map not found ../web.browser/packages/observe-sequence.js.map
[Accepted][include]:  /packages/htmljs.js
[ClientSide][Public] file instrumented: /packages/htmljs.js
[Accepted][include]:  /packages/blaze.js
[ClientSide][Public] file instrumented: /packages/blaze.js
[Accepted][include]:  /packages/spacebars.js
[ClientSide][Public] file instrumented: /packages/spacebars.js
Source map not found ../web.browser/packages/deps.js.map
Source map not found ../web.browser/packages/htmljs.js.map
Source map not found ../web.browser/packages/blaze.js.map
[Accepted][include]:  /packages/templating-compiler.js
[ClientSide][Public] file instrumented: /packages/templating-compiler.js
Source map not found ../web.browser/packages/spacebars.js.map
[Accepted][include]:  /packages/templating-runtime.js
[ClientSide][Public] file instrumented: /packages/templating-runtime.js
[Accepted][include]:  /packages/templating.js
[ClientSide][Public] file instrumented: /packages/templating.js
[Accepted][include]:  /packages/kadira_blaze-layout.js
[ClientSide][Public] file instrumented: /packages/kadira_blaze-layout.js
[Accepted][include]:  /packages/less.js
[ClientSide][Public] file instrumented: /packages/less.js
Source map not found ../web.browser/packages/templating-compiler.js.map
[Accepted][include]:  /packages/johanbrook_publication-collector.js
[ClientSide][Public] file instrumented: /packages/johanbrook_publication-collector.js
Source map not found ../web.browser/packages/templating.js.map
Source map not found ../web.browser/packages/kadira_blaze-layout.js.map
Source map not found ../web.browser/packages/templating-runtime.js.map
Source map not found ../web.browser/packages/less.js.map
[Accepted][include]:  /packages/meteortesting_mocha-core.js
[ClientSide][Public] file instrumented: /packages/meteortesting_mocha-core.js
[Accepted][include]:  /packages/lmieulet_meteor-coverage.js
[ClientSide][Public] file instrumented: /packages/lmieulet_meteor-coverage.js
[Accepted][include]:  /packages/meteortesting_mocha.js
[ClientSide][Public] file instrumented: /packages/meteortesting_mocha.js
[Accepted][include]:  /packages/webapp.js
[ClientSide][Public] file instrumented: /packages/webapp.js
[Accepted][include]:  /packages/livedata.js
[ClientSide][Public] file instrumented: /packages/livedata.js
Source map not found ../web.browser/packages/johanbrook_publication-collector.js.map
registerSourceMap ../web.browser/packages/meteortesting_mocha-core.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/mocha-core/client.js
Altered source could not be accessed: meteor://💻app/packages/meteortesting:mocha-core/client.js
Add source map for file ../web.browser/packages/meteortesting_mocha-core.js.map
registerSourceMap ../web.browser/packages/meteortesting_mocha-core.js
registerSourceMap ../web.browser/packages/lmieulet_meteor-coverage.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/meteor-coverage/client/methods.js
Altered source could not be accessed: meteor://💻app/packages/lmieulet:meteor-coverage/client/methods.js
Add source map for file ../web.browser/packages/lmieulet_meteor-coverage.js.map
registerSourceMap ../web.browser/packages/lmieulet_meteor-coverage.js
registerSourceMap ../web.browser/packages/meteortesting_mocha.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/mocha/client.js
Altered source could not be accessed: meteor://💻app/packages/meteortesting:mocha/client.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/mocha/browser-shim.js
Altered source could not be accessed: meteor://💻app/packages/meteortesting:mocha/browser-shim.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/mocha/prepForHTMLReporter.js
Altered source could not be accessed: meteor://💻app/packages/meteortesting:mocha/prepForHTMLReporter.js
Add source map for file ../web.browser/packages/meteortesting_mocha.js.map
registerSourceMap ../web.browser/packages/meteortesting_mocha.js
[Accepted][include]:  /packages/hot-code-push.js
[ClientSide][Public] file instrumented: /packages/hot-code-push.js
[Accepted][include]:  /packages/launch-screen.js
[ClientSide][Public] file instrumented: /packages/launch-screen.js
registerSourceMap ../web.browser/packages/webapp.js
Add source map for file ../web.browser/packages/webapp.js.map
registerSourceMap ../web.browser/packages/webapp.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/webapp/webapp_client.js
Altered source could not be accessed: meteor://💻app/packages/webapp/webapp_client.js
Source map not found ../web.browser/packages/livedata.js.map
[Accepted][include]:  /packages/ui.js
[ClientSide][Public] file instrumented: /packages/ui.js
[Accepted][include]:  /packages/autoupdate.js
[ClientSide][Public] file instrumented: /packages/autoupdate.js
Source map not found ../web.browser/packages/hot-code-push.js.map
Source map not found ../web.browser/packages/launch-screen.js.map
[Accepted][include]:  /app/global-imports.js
[ClientSide][Public] file instrumented: /app/global-imports.js
[Accepted][include]:  /app/app.js
[ClientSide][Public] file instrumented: /app/app.js
Source map not found ../web.browser/packages/ui.js.map
registerSourceMap ../web.browser/packages/autoupdate.js
Cannot access /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/packages/autoupdate/autoupdate_client.js
Altered source could not be accessed: meteor://💻app/packages/autoupdate/autoupdate_client.js
Add source map for file ../web.browser/packages/autoupdate.js.map
registerSourceMap ../web.browser/packages/autoupdate.js
Source map not found ../web.browser/app/global-imports.js.map
registerSourceMap ../web.browser/app/app.js
Add source map for file ../web.browser/app/app.js.map
registerSourceMap ../web.browser/app/app.js


  fake testing the front
    ✓ dumb test
    ✓ should import file


  2 passing (91ms)

Meteor-coverage is saving client side coverage to the server. Client js files saved  {"SUCCESS":73,"FAILED":0,"TOTAL":73}
All tests finished!

--------------------------------
SERVER FAILURES: 0
CLIENT FAILURES: 0
--------------------------------
Export code coverage
- Out lcovonly
export coverage using the following format [ lcovonly ] options [ { path: '/Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/.coverage',
  verbose: true } ]
Try to remove the content & create the file /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple/.coverage/lcov.info
ReportService failed while creating report type [ lcovonly ]
TypeError: mappedCoverage.addStatement is not a function
    at /Users/[email protected]/.meteor/packages/lmieulet_meteor-coverage/.1.1.4.b9h5m0.5xblf++os+web.browser+web.cordova/npm/node_modules/istanbul-lib-source-maps/lib/transformer.js:96:28
    at Array.forEach (<anonymous>)
    at SourceMapTransformer.processFile (/Users/[email protected]/.meteor/packages/lmieulet_meteor-coverage/.1.1.4.b9h5m0.5xblf++os+web.browser+web.cordova/npm/node_modules/istanbul-lib-source-maps/lib/transformer.js:87:34)
    at /Users/[email protected]/.meteor/packages/lmieulet_meteor-coverage/.1.1.4.b9h5m0.5xblf++os+web.browser+web.cordova/npm/node_modules/istanbul-lib-source-maps/lib/transformer.js:168:24
    at Array.forEach (<anonymous>)
    at SourceMapTransformer.transform (/Users/[email protected]/.meteor/packages/lmieulet_meteor-coverage/.1.1.4.b9h5m0.5xblf++os+web.browser+web.cordova/npm/node_modules/istanbul-lib-source-maps/lib/transformer.js:158:25)
    at MapStore.transformCoverage (/Users/[email protected]/.meteor/packages/lmieulet_meteor-coverage/.1.1.4.b9h5m0.5xblf++os+web.browser+web.cordova/npm/node_modules/istanbul-lib-source-maps/lib/map-store.js:138:8)
    at Object.getReport (packages/lmieulet:meteor-coverage/server/services/coverage-data.js:74:33)
    at Object.getNodeReport (packages/lmieulet:meteor-coverage/server/services/coverage-data.js:98:30)
    at Object.getTreeReport (packages/lmieulet:meteor-coverage/server/services/coverage-data.js:92:17)
    at Object.getLcovonlyReport (packages/lmieulet:meteor-coverage/server/services/coverage-data.js:95:17)
    at Object.generate (packages/lmieulet:meteor-coverage/server/report/report-generic.js:24:31)
    at Object.generateReport (packages/lmieulet:meteor-coverage/server/report/report-service.js:35:25)
    at exportFile (packages/lmieulet:meteor-coverage/server/handlers.js:70:19)
    at doCall (packages/meteorhacks_picker.js:128:14)
    at PickerImp._processRoute (packages/meteorhacks_picker.js:122:5) 'TypeError: mappedCoverage.addStatement is not a function\n    at /Users/[email protected]/.meteor/packages/lmieulet_meteor-coverage/.1.1.4.b9h5m0.5xblf++os+web.browser+web.cordova/npm/node_modules/istanbul-lib-source-maps/lib/transformer.js:96:28\n    at Array.forEach (<anonymous>)\n    at SourceMapTransformer.processFile (/Users/[email protected]/.meteor/packages/lmieulet_meteor-coverage/.1.1.4.b9h5m0.5xblf++os+web.browser+web.cordova/npm/node_modules/istanbul-lib-source-maps/lib/transformer.js:87:34)\n    at /Users/[email protected]/.meteor/packages/lmieulet_meteor-coverage/.1.1.4.b9h5m0.5xblf++os+web.browser+web.cordova/npm/node_modules/istanbul-lib-source-maps/lib/transformer.js:168:24\n    at Array.forEach (<anonymous>)\n    at SourceMapTransformer.transform (/Users/[email protected]/.meteor/packages/lmieulet_meteor-coverage/.1.1.4.b9h5m0.5xblf++os+web.browser+web.cordova/npm/node_modules/istanbul-lib-source-maps/lib/transformer.js:158:25)\n    at MapStore.transformCoverage (/Users/[email protected]/.meteor/packages/lmieulet_meteor-coverage/.1.1.4.b9h5m0.5xblf++os+web.browser+web.cordova/npm/node_modules/istanbul-lib-source-maps/lib/map-store.js:138:8)\n    at Object.getReport (packages/lmieulet:meteor-coverage/server/services/coverage-data.js:74:33)\n    at Object.getNodeReport (packages/lmieulet:meteor-coverage/server/services/coverage-data.js:98:30)\n    at Object.getTreeReport (packages/lmieulet:meteor-coverage/server/services/coverage-data.js:92:17)\n    at Object.getLcovonlyReport (packages/lmieulet:meteor-coverage/server/services/coverage-data.js:95:17)\n    at Object.generate (packages/lmieulet:meteor-coverage/server/report/report-generic.js:24:31)\n    at Object.generateReport (packages/lmieulet:meteor-coverage/server/report/report-service.js:35:25)\n    at exportFile (packages/lmieulet:meteor-coverage/server/handlers.js:70:19)\n    at doCall (packages/meteorhacks_picker.js:128:14)\n    at PickerImp._processRoute (packages/meteorhacks_picker.js:122:5)'
Error: Failed to save lcovonly coverage
    at HTTP.get (packages/meteortesting:mocha/server.handleCoverage.js:37:18)
    at runWithEnvironment (packages/meteor.js:1356:24)

> bare-exemple@ test:packages:coverage /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple
> meteor npm run test:add:packages && TEST_BROWSER_DRIVER=puppeteer COVERAGE=1 COVERAGE_OUT_HTML=1 COVERAGE_APP_FOLDER=$(pwd)/ meteor test-packages --once --driver-package=meteortesting:mocha --raw-logs


> bare-exemple@ test:add:packages /Users/[email protected]/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple
> meteor add meteortesting:[email protected]

meteortesting:mocha with version constraint 1.1.1 has already been added.

[[[[[ Tests ]]]]]

=> Started proxy.
local-test:cgalvarez:school: updating npm dependencies -- chai, sinon, sinon-chai...
=> Started MongoDB.
local-test:somepkg: updating npm dependencies -- chai, chai-as-promised...
Module load hook: transform [/private/var/folders/_f/6dzq19pj0lq8ffzvvty913q80000gn/T/meteor-test-run6k2klj.vk1js/.meteor/local/build/programs/server/packages/cgalvarez_school.js]
Module load hook: transform [/private/var/folders/_f/6dzq19pj0lq8ffzvvty913q80000gn/T/meteor-test-run6k2klj.vk1js/.meteor/local/build/programs/server/packages/local-test_cgalvarez_school.js]
Module load hook: transform [/private/var/folders/_f/6dzq19pj0lq8ffzvvty913q80000gn/T/meteor-test-run6k2klj.vk1js/.meteor/local/build/programs/server/packages/somepkg.js]
Module load hook: transform [/private/var/folders/_f/6dzq19pj0lq8ffzvvty913q80000gn/T/meteor-test-run6k2klj.vk1js/.meteor/local/build/programs/server/packages/local-test_somepkg.js]
Module load hook: transform [app/global-imports.js]

--------------------------------
----- RUNNING SERVER TESTS -----
--------------------------------



  TypeScript school package
=> Started your app.

=> App running at: http://localhost:3000/
    ✓ creates empty Hogwarts
    ✓ enrolls Harry Potter

  my package
    ✓ run some mocha test


  3 passing (53ms)


--------------------------------
----- RUNNING CLIENT TESTS -----
--------------------------------
HeadlessChrome/73.0.3679.0


  my package
    ✓ run some mocha test


  1 passing (17ms)

Meteor-coverage is saving client side coverage to the server. Client js files saved  {"SUCCESS":50,"FAILED":0,"TOTAL":50}
All tests finished!

--------------------------------
SERVER FAILURES: 0
CLIENT FAILURES: 0
--------------------------------
✔ 09:28 ~/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple [master ↑·1|✚ 2] $ ls .coverage
base.css              factory               lcov.info             prettify.js           somepkg               sorter.js
block-navigation.js   index.html            prettify.css          school                sort-arrow-sprite.png
✔ 09:28 ~/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple [master ↑·1|✚ 2] $ open .coverage/index.html
✔ 09:28 ~/src/github.com/geoffcorey/meteor-coverage-app-exemple/bare-exemple [master ↑·1|✚ 2] $ git diff
diff --git a/bare-exemple/.meteor/packages b/bare-exemple/.meteor/packages
index 26b86d2..616300f 100644
--- a/bare-exemple/.meteor/packages
+++ b/bare-exemple/.meteor/packages
@@ -23,3 +23,4 @@ [email protected]                    # Leaner CSS language

 johanbrook:publication-collector  # Test a Meteor publication by collecting its output
 [email protected]
+meteortesting:[email protected]
diff --git a/bare-exemple/.meteor/versions b/bare-exemple/.meteor/versions
index 6cb495a..7ee74e3 100644
--- a/bare-exemple/.meteor/versions
+++ b/bare-exemple/.meteor/versions
@@ -40,9 +40,14 @@ kadira:[email protected]
 [email protected]
 [email protected]
 [email protected]
+lmieulet:[email protected]
 [email protected]
 [email protected]
 [email protected]
+meteorhacks:[email protected]
+meteortesting:[email protected]
+meteortesting:[email protected]
+meteortesting:[email protected]
 [email protected]
 [email protected]
 [email protected]

@serut
Copy link
Owner

serut commented Feb 21, 2019

Sorry for the late answer.

I can confirm your issue on my side. The issue starts here:

meteor add meteortesting:[email protected]


Changes to your project's package version selections:

lmieulet:meteor-coverage     added, version 1.1.4
meteorhacks:picker           added, version 1.0.3
meteortesting:browser-tests  added, version 1.0.0
meteortesting:mocha          added, version 1.1.2
meteortesting:mocha-core     added, version 1.0.1

Why the hell installing meteortesting:mocha brings lmieulet:meteor-coverage with a wrong version ?!
It can be fixed by executing meteor update --all-packages just after that, so there is no constraint that prevent the right version to be installed..

And if you execute the command I give in the readme meteor add lmieulet:meteor-coverage meteortesting:mocha it installs the right version. So I won't explain this little issue in the readme as eveyrthing is enough complicated, and it works with what I wrote.

However, your original issue is confirmed as tests files are still in the coverage report. Need to look at it, but maybe all the system that prevents tests file to be in the report have been ignored with the new babel feature, I don't know yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geoffcorey @serut