Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initial support for fleet provisioning #540

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stuart-warren
Copy link

fixes #171

@at-wat at-wat self-requested a review June 26, 2024 15:15
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 74.20814% with 57 lines in your changes missing coverage. Please review.

Project coverage is 66.19%. Comparing base (f386de7) to head (204faa8).

Files Patch % Lines
fleetprovisioning/fleetprovisioning.go 73.97% 41 Missing and 16 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
+ Coverage   65.28%   66.19%   +0.90%     
==========================================
  Files          33       35       +2     
  Lines        1959     2180     +221     
==========================================
+ Hits         1279     1443     +164     
- Misses        584      625      +41     
- Partials       96      112      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@at-wat
Copy link
Member

at-wat commented Jul 5, 2024

Thank you for your contribution!
As I haven't used fleet provisioning feature yet, I'm gonna briefly learn the feature before reviewing

@stuart-warren stuart-warren marked this pull request as draft July 5, 2024 13:18
@stuart-warren
Copy link
Author

I think I'd like to add some options similar to how you have done so in https://github.com/seqsense/aws-iot-device-sdk-go/blob/master/jobs/option.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Device provisioning
2 participants