Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all install requirements to setup.py #67

Open
AndreasBackx opened this issue Aug 26, 2016 · 3 comments
Open

Add all install requirements to setup.py #67

AndreasBackx opened this issue Aug 26, 2016 · 3 comments

Comments

@AndreasBackx
Copy link

AndreasBackx commented Aug 26, 2016

In the readme it tells people to install pyyaml and ua-parser alongside this library. ua-parser seems to be included in the setup.py, but pyyaml is not. I'm up to make PR, but I don't know what the minimum required version of pyyaml is. Could you add pyyaml to the setup.py and edit the readme?

@robcowie
Copy link

robcowie commented Mar 26, 2017

Pretty sure this is solved by 9ad93b8 so this ticket can be closed.

@AndreasBackx
Copy link
Author

@robcowie pyyaml still doesn't seem to be added which is why I created this issue. Unless the library no longer needs it?

@robcowie
Copy link

Ah I see. I'm pretty sure the readme is wrong. pyyaml isn't a requirement for this library and it's only a requirement for ua-parser during install (it's declared in setup_requires, https://github.com/ua-parser/uap-python/blob/master/setup.py#L186).

Certainly it seems to work in a fresh virtualenv for me without explicitly installing pyyaml. Can you confirm that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@robcowie @AndreasBackx and others