Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out correct setup.py and pyproject.toml #5

Open
segevfiner opened this issue Nov 2, 2021 · 1 comment
Open

Figure out correct setup.py and pyproject.toml #5

segevfiner opened this issue Nov 2, 2021 · 1 comment

Comments

@segevfiner
Copy link
Owner

segevfiner commented Nov 2, 2021

So I tried to use setuptools' built-in support for Cython. Oh foolish me...

By including Cython in pyproject.toml/build-system.requires, distributing the C source file is kinda pointless as it will always be regenerated by the installed Cython as far as I can understand. The documentation is really confusing on the subject.

See https://groups.google.com/g/cython-users/c/C52mc9lm5xo

@segevfiner segevfiner reopened this Nov 3, 2021
@segevfiner
Copy link
Owner Author

Arghhh, so I still include cython in pyproject.toml even though it won't be needed for an sdist because otherwise pip won't install Cython before running the setup.py in development...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant