Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifiers should only be used for checks #23

Open
ImanSharaf opened this issue Nov 3, 2022 · 1 comment
Open

Modifiers should only be used for checks #23

ImanSharaf opened this issue Nov 3, 2022 · 1 comment
Labels

Comments

@ImanSharaf
Copy link

Based on this pattern, the modifiers should only be used to implement checks and not be used to change state or do an external call.

@ImanSharaf ImanSharaf added the SCP label Nov 3, 2022
@damianrusinek
Copy link
Contributor

damianrusinek commented Nov 10, 2022

Thanks for the proposal. We are continuing development of SCSVS on our for: https://github.com/ComposableSecurity/SCSVS
We will address your issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants