-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport uuid identifier related changes to support uuid based sstable identifiers #333
Comments
see also scylladb/scylladb#13932 |
I want to patch out |
@denesb hi Botond, thank you for the remarks! the recent changes of
can enable us to proceed without being blocked by this issue or your initiative to ditch |
@denesb hi Botond, i am going to add a wrapper around |
|
thank you. added to the list. |
an alternative of backport uuid identifier changes is to implement it right in scylla. see scylladb/scylladb#14856 |
this is breaking rolling upgrades tests as well and a test for GC of tomestones: |
cause of new sstable uuid identifer feature the old `sstabledump` can't currently work with those sstables Ref: scylladb/scylla-tools-java#333
cause of new sstable uuid identifer feature the old `sstabledump` can't currently work with those sstables Ref: scylladb/scylla-tools-java#333
cause of new sstable uuid identifer feature the old `sstabledump` can't currently work with those sstables Ref: scylladb/scylla-tools-java#333
cause of new sstable uuid identifer feature the old `sstabledump` can't currently work with those sstables Ref: scylladb/scylla-tools-java#333 (cherry picked from commit cd69a61)
@tchaikov - is this still the plan? |
@mykaul no, in an offline discussion with Botond, he warned me that the output format of |
I don't mind deprecating it, but it has docs implications. https://opensource.docs.scylladb.com/stable/operating-scylla/admin-tools/sstabledump.html for example. |
@mykaul hi Yaniv, please take a look at the master version https://opensource.docs.scylladb.com/master/operating-scylla/admin-tools/sstabledump.html . we are deprecating it. |
uuid-based sstable identifier was introduced by Cassandra upstream in apache/cassandra@0040fea. but our fork was based 3.x. so to support this feature, we need to merge the upstream changes or rebase on top of it. or, as put by Avi in scylladb/scylladb#13932 (comment), quoted here as well
Note that Cassandra is now at "oa" format: apache/cassandra@f16fb67.
without this change following test would be failing after enabling the
uuid_sstable_identifier_enabled
option introduced by scylladb/scylladb#13932the tests above are only a subset. following tools should be updated
The text was updated successfully, but these errors were encountered: