feat: create scylla-getting-started-golang #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rluders
suggested changes
Sep 29, 2023
There was a problem hiding this comment.
Hey, @Canhassi12. Good job! I added some comments to help you to improve the structure and the code a little bit. Hope it helps.
|
LGTM!! |
rluders
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
I've spent some time with you reviewing each item and comment I left here. In the end, we conducted a test to ensure that all system functionalities were cohesive.
There are a few minor points that could be improved, but they certainly don't prevent the contribution from being accepted - it can be improved in a separate PR since these points are just polishing. The approach is quite straightforward, and the separation of layers is coherent.
So, in summary... LGTM 😄
|
LGTM |
racerxdl
reviewed
Oct 4, 2023
racerxdl
reviewed
Oct 4, 2023
racerxdl
reviewed
Oct 4, 2023
racerxdl
reviewed
Oct 4, 2023
racerxdl
reviewed
Oct 4, 2023
racerxdl
reviewed
Oct 4, 2023
|
Congratulations!!! I learned a lot with this PR |
racerxdl
approved these changes
Oct 5, 2023
DanielHe4rt
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This PR aims to add documentation and the base project for using ScyllaDB with Golang.
I hope it was practical! If any modifications are needed, please let me know!