feat(ruby): adding ruby project #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHe4rt
approved these changes
Aug 25, 2023
|
@annastuchlik @tzach I think that's everything good to go. Maybe a last review just in case :p also @cherryramatisdev thanks for the awesome contribution! |
|
Hey @cherryramatisdev I think that we're good to go on this PR. Could you please validate if there's anything missing and rebase your branch? Thanks! |
cherryramatisdev
force-pushed
the
feat/ruby
branch
from
3dacbed
to
8db4584
Compare
|
I was reviewed a couple times and it's all good with the code propose! I did the rebase as you mentioned @DanielHe4rt Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any improvement is necessary for this PR to be merged, please let me know!