Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: information about ReplicaOrdering needed in load_balancing manual #270

Open
sylwiaszunejko opened this issue Dec 28, 2023 · 1 comment
Assignees

Comments

@sylwiaszunejko
Copy link

I would like to report an issue in page: https://github.com/scylladb/java-driver/blob/085dd34ef46b1de5111629bdccfe4056c4355676/manual/load_balancing/README.md

Problem

In TokenAwarePolicy section, there is no mention of the ReplicaOrdering field and when it should be set to ReplicaOrdering.NEUTRAL. This information is covered here:

/**
* Return the replicas in the exact same order in which they appear in the child policy's query
* plan.
*
* <p>This is the only strategy that fully respects the child policy's replica ordering. Use it
* when it is important to keep that order intact (e.g. when using the {@link
* LatencyAwarePolicy}).
*/
NEUTRAL
. Although it states that it is important for the LatencyAwarePolicy, in reality, the RackAwareRoundRobinPolicy also does not function correctly without this option.

Lack of this information in the docs is causing a problem in cassandra-stress (#255), which is currently being addressed by adding ReplicaOrdering.NEUTRAL to the TokenAwarePolicy (scylladb/scylla-tools-java#367).

@fruch
Copy link

fruch commented Dec 28, 2023

beside the docs, I think a warning of misuse might be in order...

@avelanarius avelanarius self-assigned this Jan 15, 2024
@roydahan roydahan assigned Bouncheck and unassigned avelanarius Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants