Add benchmark test suite for gocql.Marshal/Unmarshal #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test added for: * Simple data types: int, blob, text, uuid, duration, timestamp * Complex data types: list, map, set udt,tuple. * 3 level complex data type: list<map<udt<...>>>.
dkropachev
requested changes
Oct 9, 2024
| @@ -0,0 +1,331 @@ | |||
| package gocql_bench | |||
There was a problem hiding this comment.
Let's move it to tests/bench/bench_marshal_test.go
Comment on lines
+17
to
+28
| // Marshal | ||
| marshaled, err := gocql.Marshal(tType, val) | ||
| if err != nil { | ||
| b.Fatal(err) | ||
| } | ||
|
|
||
| // Unmarshal | ||
| var unmarshaled int | ||
| err = gocql.Unmarshal(tType, marshaled, &unmarshaled) | ||
| if err != nil { | ||
| b.Fatal(err) | ||
| } |
There was a problem hiding this comment.
Sorry for being confusing, but it is better to test Marshal and Unmarshal separately`
There was a problem hiding this comment.
but to test Unmarshal I need some marshled data, so in the test for unmarshaling I need to run both Marshal() and Unmarshal()? Or should we for now just test Marshal?
There was a problem hiding this comment.
call marshal once outside of the test just before t.run
| b.Run("Blob", func(b *testing.B) { | ||
| tType := gocql.NewNativeType(4, gocql.TypeBlob, "") | ||
|
|
||
| var val = []byte("test blob data") |
There was a problem hiding this comment.
for blob and text we would want to test following cases:
- Small: +-100b
- Medium: 1kb
- Big: 1M
- Huge: 10M
for text let's make it a json.
for blob a binary data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test added for:
Fixes: #295