Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is possible to use this module without specifying an aws_account_id #8

Open
jim80net opened this issue Jun 16, 2020 · 3 comments
Open
Labels
bug Something isn't working

Comments

@jim80net
Copy link
Contributor

This breaks when enable_aws_integration is not true.

@houqp
Copy link
Contributor

houqp commented Jun 17, 2020

https://github.com/scribd/terraform-aws-datadog/blob/master/examples/cloudwatch_log_sync/main.tf is already using it without account id isn't it?

@jim80net
Copy link
Contributor Author

I misrepresented the conditions for error. The module accepts invalid parameters:

  • enable_aws_integration is true, or the default value (true)
  • aws_account_id is null

I would want the module to reject this misconfiguration, rather than what it currently does, which is create a datadog aws integration with no aws_account value.

@houqp
Copy link
Contributor

houqp commented Jun 23, 2020

I see, yeah, that's a valid bug. alternatively, we can pull default aws account id withiin the datadog module if account_id is not provided but aws_integration is enabled.

@houqp houqp added the bug Something isn't working label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants