From fe05a203e5ddeb4fde334bd5221be49184fa90b2 Mon Sep 17 00:00:00 2001 From: Bulat Khabibullin Date: Tue, 29 Aug 2023 22:19:49 +0500 Subject: [PATCH] Drop python 3.7 support (#155) --- .github/workflows/test.yml | 8 ++++---- README.rst | 2 +- docs/intro/install.rst | 2 +- setup.py | 1 - tests/test_injection.py | 2 +- tox.ini | 11 ++++++----- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e1fcd849..94adcf03 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -16,13 +16,13 @@ jobs: fail-fast: false matrix: include: - - python-version: "3.7" + - python-version: "3.8" toxenv: "min" - - python-version: "3.7" + - python-version: "3.8" toxenv: "pinned-scrapy-2x7" - - python-version: "3.7" + - python-version: "3.8" toxenv: "pinned-scrapy-2x8" - - python-version: "3.7" + - python-version: "3.8" toxenv: "asyncio-min" - python-version: "3.8" - python-version: "3.9" diff --git a/README.rst b/README.rst index fef8226f..548aeaf0 100644 --- a/README.rst +++ b/README.rst @@ -48,7 +48,7 @@ Installation pip install scrapy-poet -Requires **Python 3.7+** and **Scrapy >= 2.6.0**. +Requires **Python 3.8+** and **Scrapy >= 2.6.0**. Usage in a Scrapy Project ========================= diff --git a/docs/intro/install.rst b/docs/intro/install.rst index 0d542140..9011a252 100644 --- a/docs/intro/install.rst +++ b/docs/intro/install.rst @@ -7,7 +7,7 @@ Installation Installing scrapy-poet ====================== -``scrapy-poet`` is a Scrapy extension that runs on Python 3.7 and above. +``scrapy-poet`` is a Scrapy extension that runs on Python 3.8 and above. If you’re already familiar with installation of Python packages, you can install ``scrapy-poet`` and its dependencies from PyPI with: diff --git a/setup.py b/setup.py index 0fed5ef1..a9908ec6 100755 --- a/setup.py +++ b/setup.py @@ -38,7 +38,6 @@ "Operating System :: OS Independent", "Framework :: Scrapy", "Programming Language :: Python :: 3", - "Programming Language :: Python :: 3.7", "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", diff --git a/tests/test_injection.py b/tests/test_injection.py index 0e7d59a6..e0e6cd00 100644 --- a/tests/test_injection.py +++ b/tests/test_injection.py @@ -287,7 +287,7 @@ class OtherEurDollarRate(Injectable): @attr.s(auto_attribs=True) class PricePO(ItemPage, ResponseShortcutsMixin): - response: Html + response: Html # type: ignore[assignment] def to_item(self): return dict(price=float(self.css(".price::text").get()), currency="€") diff --git a/tox.ini b/tox.ini index 47276f09..3ea17524 100644 --- a/tox.ini +++ b/tox.ini @@ -1,11 +1,12 @@ [tox] -envlist = min,py37,py38,py39,py310,py311,asyncio,asyncio-min,mypy,docs +envlist = min,py38,py39,py310,py311,asyncio,asyncio-min,mypy,docs [testenv] deps = pytest pytest-cov pytest-twisted + Twisted<=22.10.0 commands = py.test \ @@ -24,7 +25,7 @@ deps = web-poet==0.7.0 [testenv:min] -basepython = python3.7 +basepython = python3.8 deps = {[pinned]deps} scrapy==2.6.0 @@ -38,7 +39,7 @@ deps = # Before ``scrapy.http.request.NO_CALLBACK`` was introduced. # See: https://github.com/scrapinghub/scrapy-poet/issues/48 [testenv:pinned-scrapy-2x7] -basepython=python3.7 +basepython=python3.8 deps = {[pinned]deps} scrapy==2.7.0 @@ -46,7 +47,7 @@ deps = # After ``scrapy.http.request.NO_CALLBACK`` was introduced. # See: https://github.com/scrapinghub/scrapy-poet/issues/118 [testenv:pinned-scrapy-2x8] -basepython=python3.7 +basepython=python3.8 deps = {[pinned]deps} scrapy==2.8.0 @@ -60,7 +61,7 @@ deps = {[pinned]deps} [testenv:asyncio-min] -basepython = python3.7 +basepython = python3.8 setenv = {[testenv:asyncio]setenv} commands =