Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 and 3.12-minimal with C10S #711

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Conversation

befeleme
Copy link
Member

  • enchant and atlas-devel are no longer available in the distribution - removed them for now but without knowing what they were responsible for, I can't really tell if that's enough or we should find a replacement.

@befeleme
Copy link
Member Author

[test]

@frenzymadness
Copy link
Member

Atlas is for linear algebra (scientific applications) and enchant is an abstraction for spell-checking. Will see what will happen without them. I don't think we have a test or an internal functionalities requiring those two so we should be fine.

@befeleme
Copy link
Member Author

micropipenv-requirements-test-app failed with the traceback:

Wed Sep 11 10:58:34.578491 2024] [wsgi:error] [pid 9:tid 9] mod_wsgi (pid=9): Exception occurred processing WSGI script '/tmp/mod_wsgi-localhost:8080:100001/handler.wsgi'.
[Wed Sep 11 10:58:34.579949 2024] [wsgi:error] [pid 9:tid 9] Traceback (most recent call last):
[Wed Sep 11 10:58:34.580312 2024] [wsgi:error] [pid 9:tid 9]   File "/tmp/mod_wsgi-localhost:8080:100001/handler.wsgi", line 90, in <module>
[Wed Sep 11 10:58:34.580454 2024] [wsgi:error] [pid 9:tid 9]     handler = mod_wsgi.server.ApplicationHandler(entry_point,
[Wed Sep 11 10:58:34.580603 2024] [wsgi:error] [pid 9:tid 9]               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[Wed Sep 11 10:58:34.580736 2024] [wsgi:error] [pid 9:tid 9]   File "/opt/app-root/lib64/python3.12/site-packages/mod_wsgi/server/__init__.py", line 1457, in __init__
[Wed Sep 11 10:58:34.580883 2024] [wsgi:error] [pid 9:tid 9]     __import__(entry_point)
[Wed Sep 11 10:58:34.581017 2024] [wsgi:error] [pid 9:tid 9]   File "/opt/app-root/src/wsgi.py", line 1, in <module>
[Wed Sep 11 10:58:34.581156 2024] [wsgi:error] [pid 9:tid 9]     import enchant
[Wed Sep 11 10:58:34.581297 2024] [wsgi:error] [pid 9:tid 9]   File "/opt/app-root/lib64/python3.12/site-packages/enchant/__init__.py", line 81, in <module>
[Wed Sep 11 10:58:34.581431 2024] [wsgi:error] [pid 9:tid 9]     from enchant import _enchant as _e
[Wed Sep 11 10:58:34.581602 2024] [wsgi:error] [pid 9:tid 9]   File "/opt/app-root/lib64/python3.12/site-packages/enchant/_enchant.py", line 157, in <module>
[Wed Sep 11 10:58:34.581610 2024] [wsgi:error] [pid 9:tid 9]     raise ImportError(msg)
[Wed Sep 11 10:58:34.581629 2024] [wsgi:error] [pid 9:tid 9] ImportError: The 'enchant' C library was not found and maybe needs to be installed.
[Wed Sep 11 10:58:34.581633 2024] [wsgi:error] [pid 9:tid 9] See  https://pyenchant.github.io/pyenchant/install.html
[Wed Sep 11 10:58:34.581635 2024] [wsgi:error] [pid 9:tid 9] for details

I checked the test, it just imports enchant, doesn't really do anything with it. So let's just remove it and see what happens.

[test]

@befeleme
Copy link
Member Author

Now the tests run successfully. Can we drop enchant like that? Since the C library is no longer available in the distro, whoever needs it, will have to find another way.

@phracek
Copy link
Member

phracek commented Sep 13, 2024

Thanks for this Pull request. You do GREAT jobs. Or maybe better say AWESOME job/

@phracek
Copy link
Member

phracek commented Sep 16, 2024

[test]

@phracek
Copy link
Member

phracek commented Sep 17, 2024

Waw. We are GREEN. Good job. Please review it.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The tests are GREEN

@hrnciar
Copy link
Member

hrnciar commented Sep 18, 2024

+1, LGTM

@phracek phracek merged commit b819b60 into sclorg:master Sep 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants