Fix the openshift templates #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
metlos
commented
Sep 20, 2024
metlos
commented
- Specify that the postgresql images should be taken from openshift
- Use an init container in the rails-postgresql template to init the database
* Specify that the postgresql images should be taken from openshift * Use an init container in the rails-postgresql template to init the database
metlos
added a commit
to metlos/cluster-samples-operator
that referenced
this pull request
Sep 20, 2024
|
[test] |
phracek
requested changes
Sep 23, 2024
| @@ -408,7 +408,7 @@ | |||
| "annotations": { | |||
| "description": "Defines how to deploy the database", | |||
| "template.alpha.openshift.io/wait-for-ready": "true", | |||
| "image.openshift.io/triggers": "[{\"from\":{\"kind\":\"ImageStreamTag\",\"name\":\"postgresql:${POSTGRESQL_VERSION}\"},\"fieldPath\": \"spec.template.spec.containers[0].image\"}]" | |||
| "image.openshift.io/triggers": "[{\"from\":{\"kind\":\"ImageStreamTag\",\"name\":\"postgresql:${POSTGRESQL_VERSION}\", \"namespace\": \"openshift\"},\"fieldPath\": \"spec.template.spec.containers[0].image\"}]" | |||
There was a problem hiding this comment.
This is not needed. Before testing you are already in required 'namespace'
There was a problem hiding this comment.
Or use variable https://github.com/sclorg/rails-ex/blob/master/openshift/templates/rails-postgresql-persistent.json#L522, that is better approach
| @@ -316,7 +396,7 @@ | |||
| "annotations": { | |||
| "description": "Defines how to deploy the database", | |||
| "template.alpha.openshift.io/wait-for-ready": "true", | |||
| "image.openshift.io/triggers": "[{\"from\":{\"kind\":\"ImageStreamTag\",\"name\":\"postgresql:12-el8\"},\"fieldPath\": \"spec.template.spec.containers[0].image\"}]" | |||
| "image.openshift.io/triggers": "[{\"from\":{\"kind\":\"ImageStreamTag\",\"name\":\"postgresql:12-el8\", \"namespace\": \"openshift\"},\"fieldPath\": \"spec.template.spec.containers[0].image\"}]" | |||
…mage and remove the recreteParams that were not exactly working well. The intended function is done by the initContainer.
phracek
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.