Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding groomed jet radius and momentum balance for the soft drop groomed jet #303

Open
kawaho opened this issue Jul 1, 2024 · 6 comments · May be fixed by #312
Open

Adding groomed jet radius and momentum balance for the soft drop groomed jet #303

kawaho opened this issue Jul 1, 2024 · 6 comments · May be fixed by #312

Comments

@kawaho
Copy link

kawaho commented Jul 1, 2024

I am proposing to add the groomed jet radius and momentum balance in the return output of the exclusive_jets_softdrop_grooming function. These two are commonly studied jet substructure variables. The change is simple by basically calling

groomed_jet.structure_of<fastjet::contrib::SoftDrop>().delta_R();
groomed_jet.structure_of<fastjet::contrib::SoftDrop>(). symmetry();

and adding the results to the outputs. I am happy to make a pull request if this proposal is accepted.
@matthewfeickert
Copy link
Member

@jmduarte @chrispap95 @lgray can you give @kawaho some feedback on this proposal?

@rkansal47
Copy link
Collaborator

Hi sorry for the late response, indeed, this sounds like a useful addition @kawaho! Please go ahead with the PR.

@kawaho
Copy link
Author

kawaho commented Sep 11, 2024

Thanks @rkansal47 and @matthewfeickert , closing the issue now.

@kawaho kawaho closed this as completed Sep 11, 2024
@matthewfeickert
Copy link
Member

@kawaho Please do not close issues in advance of completion. Instead use GitHub's keywords in the body of the implimenting PR to close them.

@kawaho kawaho linked a pull request Sep 11, 2024 that will close this issue
Draft
@kawaho
Copy link
Author

kawaho commented Sep 11, 2024

Apologies, this is my first PR. I have referenced this issue in the PR made.

@matthewfeickert
Copy link
Member

You're good. Nothing to apologize about. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@matthewfeickert @rkansal47 @kawaho