Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: pytest 8.1.1 compatibility #242

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Mar 9, 2024

8.1.1 contains the consider_namespace_packages that were addressed in #241 However the fix assumed those changes would be in 8.2 instead of 8.1.1.

This PR adjusts the version check to include the fix for 8.1.1

Fixes #243

@bsipocz bsipocz added this to the 1.3.0 milestone Mar 10, 2024
@bsipocz bsipocz merged commit 1139325 into scientific-python:main Mar 10, 2024
20 checks passed
@bsipocz
Copy link
Member

bsipocz commented Mar 10, 2024

Thanks!

@bsipocz
Copy link
Member

bsipocz commented Mar 10, 2024

I suppose we need to do a release, and given this is the only change, I'll do it as a 1.2.1

@bsipocz bsipocz modified the milestones: 1.3.0, 1.2.1 Mar 10, 2024
@pllim
Copy link
Contributor

pllim commented Mar 11, 2024

I just assumed people don't do breaking changes in a bug fix release. Obviously I was wrong. Thank you all for reporting and fixing this over the weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doctestplus failure with pytest 8.1.1
3 participants