From 73425932be1d4eb2748ec70dcb5e2dd65d112252 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Doeraene?= Date: Tue, 20 Feb 2024 15:23:07 +0100 Subject: [PATCH 1/2] Post release v1.3.0. Set `versionPolicyIntention` to `BinaryAndSourceCompatible` for the upcoming v1.3.1. Remove previous MiMa filters. --- build.sbt | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/build.sbt b/build.sbt index 36156f0e..f0f496e6 100644 --- a/build.sbt +++ b/build.sbt @@ -37,7 +37,7 @@ inThisBuild(Def.settings( Developer("sjrd", "Sébastien Doeraene", "sjrdoeraene@gmail.com", url("https://github.com/sjrd/")), Developer("bishabosha", "Jamie Thompson", "bishbashboshjt@gmail.com", url("https://github.com/bishabosha")), ), - versionPolicyIntention := Compatibility.BinaryCompatible, + versionPolicyIntention := Compatibility.BinaryAndSourceCompatible, // Ignore dependencies to internal modules whose version is like `1.2.3+4...` (see https://github.com/scalacenter/sbt-version-policy#how-to-integrate-with-sbt-dynver) versionPolicyIgnoredInternalDependencyVersions := Some("^\\d+\\.\\d+\\.\\d+\\+\\d+".r) )) @@ -126,16 +126,6 @@ lazy val tastyQuery = mimaBinaryIssueFilters ++= { import com.typesafe.tools.mima.core.* Seq( - // private[tastyquery], not an issue - ProblemFilters.exclude[DirectMissingMethodProblem]("tastyquery.Contexts#Context.classloader"), - ProblemFilters.exclude[MissingClassProblem]("tastyquery.Utils"), - ProblemFilters.exclude[MissingClassProblem]("tastyquery.Utils$"), - // private, not an issue - ProblemFilters.exclude[MissingClassProblem]("tastyquery.Types$TermRef$Resolved"), - ProblemFilters.exclude[MissingClassProblem]("tastyquery.Types$TypeRef$Resolved"), - - // Everything in tastyquery.reader is private[tastyquery] at most - ProblemFilters.exclude[Problem]("tastyquery.reader.*"), ) }, From 0dc38b9dbb3402f08d1f33c6cbe853c55eb7441b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Doeraene?= Date: Tue, 20 Feb 2024 15:24:52 +0100 Subject: [PATCH 2/2] Upgrade to sbt-tasty-mima 1.2.0. And re-enable tasty-mima checking, now that it supports Scala 3.4.x. --- build.sbt | 3 +-- project/plugins.sbt | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/build.sbt b/build.sbt index f0f496e6..c60f0574 100644 --- a/build.sbt +++ b/build.sbt @@ -129,8 +129,7 @@ lazy val tastyQuery = ) }, - // Temporarily disabled until we have a published version of tasty-query that can handle 3.4.x. - //tastyMiMaPreviousArtifacts := mimaPreviousArtifacts.value, + tastyMiMaPreviousArtifacts := mimaPreviousArtifacts.value, tastyMiMaConfig ~= { prev => import tastymima.intf._ prev diff --git a/project/plugins.sbt b/project/plugins.sbt index 0969c8da..b7e46c60 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -5,4 +5,4 @@ addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.4") addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.5.10") addSbtPlugin("ch.epfl.scala" % "sbt-version-policy" % "2.1.0") -addSbtPlugin("ch.epfl.scala" % "sbt-tasty-mima" % "1.1.0") +addSbtPlugin("ch.epfl.scala" % "sbt-tasty-mima" % "1.2.0")