From c5db9c662b63f9c41ba00e7961cbb7f1de996862 Mon Sep 17 00:00:00 2001 From: Tomasz Godzik Date: Wed, 28 Sep 2022 17:50:57 +0200 Subject: [PATCH] bugfix: Try to download semanticdb even if it might not be supported Previously, we would not download semanticdb even if it was backpublished. Now, we will try to download, but not print any warning if it's unsupported. --- .../src/main/scala/bloop/engine/BuildLoader.scala | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/frontend/src/main/scala/bloop/engine/BuildLoader.scala b/frontend/src/main/scala/bloop/engine/BuildLoader.scala index b826bb0dcf..3f9ba3f27a 100644 --- a/frontend/src/main/scala/bloop/engine/BuildLoader.scala +++ b/frontend/src/main/scala/bloop/engine/BuildLoader.scala @@ -211,11 +211,9 @@ object BuildLoader { ): Option[AbsolutePath] = { val (scalaVersion, scalaSemanticdbSettings) = scalaSemanticdbVersionAndSettings // Recognize 2.12.8-abdcddd as supported if 2.12.8 exists in supported versions - val isUnsupportedVersion = - !scalaSemanticdbSettings.supportedScalaVersions.exists(scalaVersion.startsWith(_)) - if (isUnsupportedVersion) { - if (!scalaVersion.startsWith("3.")) - logger.debug(Feedback.skippedUnsupportedScalaMetals(scalaVersion))(DebugFilter.All) + val isSupportedVersion = + scalaSemanticdbSettings.supportedScalaVersions.exists(scalaVersion.startsWith(_)) + if (scalaVersion.startsWith("3.")) { None } else { SemanticDBCache.fetchScalaPlugin( @@ -226,9 +224,13 @@ object BuildLoader { case Right(path) => logger.debug(Feedback.configuredMetalsScalaProjects(projects))(DebugFilter.All) Some(path) - case Left(cause) => + case Left(cause) if isSupportedVersion => logger.displayWarningToUser(Feedback.failedMetalsScalaConfiguration(scalaVersion, cause)) None + + // We try to download anyway, but don't print the exception + case _ => + None } } }