Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple incorrect and failure about Korean ordinal conversion #555

Open
dogzz9445 opened this issue Jan 5, 2024 · 0 comments · May be fixed by #556
Open

Multiple incorrect and failure about Korean ordinal conversion #555

dogzz9445 opened this issue Jan 5, 2024 · 0 comments · May be fixed by #556

Comments

@dogzz9445
Copy link

There are several issues with the Korean ordinal conversion in the to_ordinal function.

  1. The function throws an error when the input is 100 or 1000.
  2. The function always appends '번째' to the ordinal, which may not always be desired. For example, when converting 100, the output should be '백', not '백 번째'.
  3. The function does not consider different ways of expressing 1 in Korean. In Korean, 1 can be expressed as '첫 번째' or '한번' in ordinal form.

Expected Behaviour

num2words.num2words(100, ordinal=True, lang='ko')
'백 번째'
num2words.num2words(100, ordinal=True, lang='ko')
'십만 번째'

There are errors on 100, 1000

Actual Behaviour

num2words.num2words(100, ordinal=True, lang='ko')
===========================================================
ERROR: test_ordinal (tests.test_ko.Num2WordsKOTest.test_ordinal)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "d:\git\num2words\tests\test_ko.py", line 89, in test_ordinal
    self.assertEqual(n2k(num, to="ordinal"), out)
                     ^^^^^^^^^^^^^^^^^^^^^^
  File "d:\git\num2words\tests\test_ko.py", line 26, in n2k
    return num2words(*args, lang='ko', **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "d:\git\num2words\num2words\__init__.py", line 104, in num2words
    return getattr(converter, 'to_{}'.format(to))(number, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "d:\git\num2words\num2words\lang_KO.py", line 110, in to_ordinal
    lastwords[-1] = self.ords[lastwords[-1]]
                    ~~~~~~~~~^^^^^^^^^^^^^^^
KeyError: ''
num2words.num2words(100000, ordinal=True, lang='ko')
'열만 번째'

Steps to reproduce

  1. Run the to_ordinal function with 100 or 1000 as input without error.
  2. Observe the error.
  3. Observe the incorrect ordinal conversion.

Suggested Test Code Snippet

  1. Without Error ASAP
def test_ordinal(self):
    cases = [(1, "첫 번째"), (101, "백 한 번째"), (2, "두 번째"), (5, "다섯 번째"),
             (10, "열 번째"), (25, "스물다섯 번째"), (100, "백 번째"), 
             (1000, "천 번째"), (10000, "만 번째"), (100000, "십만 번째"),
             (137, "백 서른일곱 번째")]
    for num, out in cases:
        self.assertEqual(n2k(num, to="ordinal"), out)
  1. Suggest Appropriate Case If Possible
    In the case below, it is left to the developer's authority to attach '번, 번째, 째, 차'.
def test_ordinal(self):
    cases = [(1, "한"), (101, "백 한"), (2, "둘"), (5, "다섯"),
             (10, "열"), (25, "스물다섯"), (100, "백"), 
             (1000, "천"), (10000, "만"), (100000, "십만"),
             (137, "백 서른일곱")]
    for num, out in cases:
        self.assertEqual(n2k(num, to="ordinal"), out)
dogzz9445 added a commit to dogzz9445/num2words that referenced this issue Jan 5, 2024
@dogzz9445
Fix error about Korean ordinal conversion, only errors on issue savoi…
17e2c85 
…rfairelinux#555
@dogzz9445 dogzz9445 linked a pull request Jan 5, 2024 that will close this issue
Open
2 tasks
dogzz9445 added a commit to dogzz9445/num2words that referenced this issue Feb 3, 2024
@dogzz9445
Edit pass flake8 requirements for PR savoirfairelinux#555, Fix error …
0ac94f0 
…Korean ordinal conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error about Korean ordinal conversion, only errors on issue #555 dogzz9445/num2words
1 participant
@dogzz9445