Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the value of maybeInitProperties()? #34

Open
Jrodseth opened this issue May 11, 2017 · 1 comment
Open

What's the value of maybeInitProperties()? #34

Jrodseth opened this issue May 11, 2017 · 1 comment

Comments

@Jrodseth
Copy link

Why check if any of the private fields need to be initialized every time onDependentViewChanged is called? Do you expect the values to be reset to 0 by something?

@Override public boolean onDependentViewChanged(CoordinatorLayout parent, CircleImageView child, View dependency) { maybeInitProperties(child, dependency);

I would think initializing them once would be enough so I'm wondering if I'm missing something that requires this approach?

@drinfernoo
Copy link

Also, the mCustom... attributes are set from XML in the constructor, but never read?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants