Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSH connection] Add password authentication #294

Open
shenzj1994 opened this issue May 16, 2023 · 2 comments · May be fixed by #1126
Open

[SSH connection] Add password authentication #294

shenzj1994 opened this issue May 16, 2023 · 2 comments · May be fixed by #1126
Assignees
Labels
feature request New feature or request

Comments

@shenzj1994
Copy link

Is your feature request related to a problem? Please describe.
While the extension supports private key authentication, many SAS environments still use username and password authentication for SSH.

Describe the solution you'd like
Add password authentication capability

Describe alternatives you've considered
Technically, key pairs can be added to SAS host but this requires IT changes and significant effort. Also it may involve other security concerns.

Additional context
Suggested by @smorrisj to submit this as a new feature request. See #61

Environment
Remote SAS 9.4

@smorrisj
Copy link
Contributor

For this issue, it would be beneficial to look into the secrets storage api to house the credentials. I'm thinking of an auth flow similar to what we do for viya connections. The user would be prompted once to set the credentials, and the extension should store these in a secret.

The shh connection profile model should be augmented to discriminate between the two supported auth types for sas 9.4 remote, so that the ssh client can be built up using either the agent socket or the credentials in the secret. The username should be completely removed from the ssh profile model. For the ssh agent based auth, it can be placed in $HOME/.ssh/config as is currently done with the private key file path.

@snlwih snlwih added the feature request New feature or request label Dec 7, 2023
@snlwih snlwih changed the title Add password authentication for remote SAS 9.4 SAS 9 - SSH connection - Add password authentication Dec 7, 2023
@snlwih snlwih changed the title SAS 9 - SSH connection - Add password authentication SAS 9 SSH connection - Add password authentication Dec 7, 2023
@chunky
Copy link

chunky commented Jun 20, 2024

Using VS Code secrets storage would be much preferable, in a big-picture sense, but a rapid/tactical solution for "authentication methods involving passwords" would be immensely useful.

If there's a path by which something can be done quickly while still being adequately secure [eg, users enter password just-in-time, without a storage option], that would greatly help us.

@snlwih snlwih changed the title SAS 9 SSH connection - Add password authentication [SSH connection] Add password authentication Jul 4, 2024
@snlwih snlwih added this to the Candidate issues milestone Jul 29, 2024
@smorrisj smorrisj linked a pull request Aug 1, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants