Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Review changes" pane is not showing diffs #7297

Open
good-idea opened this issue Aug 2, 2024 · 0 comments
Open

"Review changes" pane is not showing diffs #7297

good-idea opened this issue Aug 2, 2024 · 0 comments
Labels

Comments

@good-idea
Copy link

Describe the bug

The "Review changes" pane shows menu items for document revisions, but the pane itself always shows "There are no changes".

To Reproduce

I'm not sure how to reproduce or debug this. See notes in additional context below.

Expected behavior

Document revisions & diffs should show up in the pane.

Screenshots

image

Which versions of Sanity are you using?

@sanity/cli (global)                   3.52.4 (up to date)
@sanity/color-input                     3.1.1 (up to date)
@sanity/dashboard                       4.0.0 (up to date)
@sanity/document-internationalization   3.0.0 (up to date)
@sanity/eslint-config-studio            4.0.0 (up to date)
@sanity/studio-secrets                  3.0.0 (up to date)
@sanity/vision                         3.52.4 (up to date)
sanity                                 3.52.4 (up to date)

What operating system are you using?

OS X

Which versions of Node.js / npm are you running?

Run npm -v && node -v in the terminal and copy-paste the result here.

9.8.1
v18.18.0

Additional context

Add any other context about the problem here.

  • This is on our production dataset which is quite large. (25-30k documents). However, about 80% of those are synced from an external source and rarely get updated. The documents that are getting a lot of attention probably number in the dozens.
  • Oddly, it works as expected on the development dataset - it also has nearly the same amount of documents, but is not edited as often.
  • If I make an edit (and do not publish), that change does show up in the diff:
    image
    • It continues to appear with a refresh
    • It continues to appear after publishing and refreshing
  • There is a network request to https://<projectId>.api.sanity.io/v2024-05-28/data/doc/production/drafts.homepage,homepage?tag=sanity.studio.document.snapshots, it returns one result
  • There is a network request to https://<projectId>.api.sanity.io/v2024-05-28/data/history/production/transactions/homepage,drafts.homepage?tag=sanity.studio.structure.history&effectFormat=mendoza&excludeContent=true&excludeMutations=true&includeIdentifiedDocumentsOnly=true&reverse=true&limit=50 that DOES include the recent change I made, and 49 other JSON objects with document revisions.

Because of this last note, I feel that the issue lies somewhere between that request and what is rendered - for some reason all of these seem to be filtered out at some point.

@runeb runeb added the bug label Oct 3, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants