Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fedora StorageAdapter finds root node for nil identifer #905

Open
no-reply opened this issue Jun 16, 2022 · 0 comments
Open

Fedora StorageAdapter finds root node for nil identifer #905

no-reply opened this issue Jun 16, 2022 · 0 comments

Comments

@no-reply
Copy link
Contributor

no-reply commented Jun 16, 2022 •
edited
Loading 

adapter = ::Valkyrie::Storage::Fedora.new(connection: my_connection))
adapter.find_by(id: nil)

gives the RDF for the root node:

#<Valkyrie::StorageAdapter::StreamFile id=nil io=#<Valkyrie::Storage::Fedora::IOProxy:0x00007fbef52d2380 @source="@prefix premis:  <http://www.loc.gov/premis/rdf/v1#> .\n@prefix test:  <info:fedora/test/> .\n@prefix rdfs:  <http://www.w3.org/...

it should instead raise an error. likely this applies to any id that doesn't match an ldp:NonRDFSource, which is kinda neat, but probably not what we want.
no-reply pushed a commit to samvera/hyrax that referenced this issue Jun 16, 2022
better handling for error cases in FileMetadata.find
2d17b97 
the base case originally tested relied on a bug in
Valkyrie (samvera/valkyrie#905).

this reimplements with a more serious error handling approach.
@no-reply no-reply mentioned this issue Jun 16, 2022
Merged
no-reply pushed a commit to samvera/hyrax that referenced this issue Jun 16, 2022
better handling for error cases in FileMetadata.find
fb8c75d 
the base case originally tested relied on a bug in
Valkyrie (samvera/valkyrie#905).

this reimplements with a more serious error handling approach.
no-reply pushed a commit to samvera/hyrax that referenced this issue Jun 16, 2022
better handling for error cases in FileMetadata.find
35e38a9 
the base case originally tested relied on a bug in
Valkyrie (samvera/valkyrie#905).

this reimplements with a more serious error handling approach.
dunn pushed a commit to samvera/hyrax that referenced this issue Jun 17, 2022
@dunn
better handling for error cases in FileMetadata.find
aaa7626 
the base case originally tested relied on a bug in
Valkyrie (samvera/valkyrie#905).

this reimplements with a more serious error handling approach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@no-reply