don't limit TableBasedAuthority#all

[no-reply]

authorities with more than 1000 entries have erratic behavior due to

questioning_authority/lib/qa/authorities/local/table_based_authority.rb

Line 47 in 2271be6

output_set(base_relation.limit(1000))

it seems like it would be good enough to just remove the limit.

[elrayle]

Rather than remove the limit, I would be inclined to make it configurable. If the configured limit is nil, that can be used to effectively remove the limit.

Change to something like...

    def all
      Qa.config.tablebased_all_limit&.positive? ? output_set(base_relation.limit(1000)) : output_set(base_relation)
    end

The config would default to 1000 to maintain backward compatibility.