Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the RSpec test suites #267

Open
jrgriffiniii opened this issue Aug 9, 2019 · 1 comment
Open

Refactor the RSpec test suites #267

jrgriffiniii opened this issue Aug 9, 2019 · 1 comment
Labels

Comments

@jrgriffiniii
Copy link
Contributor

While resolving #260, @elrayle noted that it would be desirable to refactor at least some of the existing tests in order to address the following:

When first written, they were written very specific to the authorities that are configured in QA. But now there are a lot of configs available the vast majority of which are not delivered with QA. But they are all expected to be able to work. It is on my TODO list to go through these tests and make them

  • easier to read
  • less dependent on OCLC/LOC (a lot of duplication in the tests by checking the same thing for both authorities)
  • clean up the fixture authorities in favor of doing more stubbing
  • move tests to the lowest place they can be tested (right now the controller is doing most of the testing instead of the classes that actually create the responses)

I apologize should this issue constitute an epic one, and require further derivative issues in order to render these tasks actionable.

@elrayle
Copy link
Contributor

elrayle commented Aug 12, 2019

Thanks for summarizing our discussions so the intention to refactor doesn't get lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants