Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Print EOF or nil error #199

Open
wrfly opened this issue Nov 21, 2018 · 0 comments
Open

Print EOF or nil error #199

wrfly opened this issue Nov 21, 2018 · 0 comments

Comments

@wrfly
Copy link

wrfly commented Nov 21, 2018

go-zookeeper/zk/conn.go

Lines 510 to 512 in c4fab1a

if err != nil || c.logInfo {
c.logger.Printf("Send loop terminated: err=%v", err)
}

go-zookeeper/zk/conn.go

Lines 525 to 527 in c4fab1a

if err != io.EOF || c.logInfo {
c.logger.Printf("Recv loop terminated: err=%v", err)
}

I don't think it's OK to print the EOF error or nil error only because the logInfo flag, since the message won't help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant