Add NamedFeature for common interface to name in bed or interval_list #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbergelson
requested changes
Aug 9, 2023
There was a problem hiding this comment.
@rickymagner I think this is a good idea but I don't think the name is right. Maybe NamedFeature would make more sense?
| * An interface for features provided via an interval file, e.g. bed or interval_list. | ||
| * Provides a common interface for accessing the name column for both of these file types. | ||
| */ | ||
| public interface IntervalFileFeature extends Feature { |
There was a problem hiding this comment.
I might call this "NamedFeature"
There was a problem hiding this comment.
Good point. I just updated the name to the more descriptive NamedFeature.
|
Ack, I merged without fixing the commit name... .bleh. |
rickymagner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This short PR adds an
IntervalFileFeatureinterface which extends theFeatureinterface to include agetNamemethod common to both lines in bed files and interval_list files. This allows you to be able to parse and work with bed and interval_list file lines uniformly when you need to access metadata in thenamefield. This will be used in an upcoming change in GATK.