Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KingDta::Account does not accept bank numbers longer than 8 digits #13

Open
iblue opened this issue Sep 17, 2013 · 0 comments
Open

KingDta::Account does not accept bank numbers longer than 8 digits #13

iblue opened this issue Sep 17, 2013 · 0 comments

Comments

@iblue
Copy link
Contributor

iblue commented Sep 17, 2013

We are doing bank transfers to the USA, where the DTAZV format is needed. Transfers are done via routing number and BIC codes. A U.S. bank routing number is 9 digits, while KingDta::Account accepts 8 digits only.

I would fix this myself, but are not sure, which would be the best option.

  • Option A: Subclass KingDta::Account to a KingDta::DtazvAccount where longer bank_numbers and bank_account_numbers are allowed.
  • Option B: Move the length check to KingDta::Dtaus, so that the allowed length is checked depending on the format (DTAZV allows longer numbers than DTAUS).

Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant