Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): add missing methods from LightningElement @W-16614337 #4585

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Sep 27, 2024

Details

This adds setAttribute and removeAttribute to the SSR implementation of LightningElement. It also adds stubs for methods that we may want to add in the future, so that we can more easily keep track of the gaps.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf requested a review from a team as a code owner September 27, 2024 20:18
@wjhsf wjhsf enabled auto-merge (squash) September 27, 2024 20:48
@wjhsf wjhsf merged commit 40e9112 into master Sep 27, 2024
11 checks passed
@wjhsf wjhsf deleted the mob/ssr-lightning-element branch September 27, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants