From ce7afdd742d7e7dfc8c9848b6e25c551f08fa715 Mon Sep 17 00:00:00 2001
From: Said Sef <6002187+saidsef@users.noreply.github.com>
Date: Wed, 10 Apr 2024 18:12:05 +0100
Subject: [PATCH] chore: Apache NiFi and Zookeepr minor version bumps (#33)

* chore: Apache NiFi and Zookeepr minor version bumps

Signed-off-by: Said Sef <saidsef@gmail.com>

* chore: update CI workflow to trigger of deployment folder modified

Signed-off-by: Said Sef <saidsef@gmail.com>

* chore: remove upload of files ro relase

Closes: #28

As we create a GitHub tag and a release there is no point in uploading K8s yaml files

---------

Signed-off-by: Said Sef <saidsef@gmail.com>
---
 .github/workflows/ci.yml           | 4 ++--
 .github/workflows/release.yml      | 9 ---------
 deployment/nifi/nifi.yml           | 2 +-
 deployment/zookeeper/zookeeper.yml | 2 +-
 4 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index f9b18bf..e1046dc 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -6,13 +6,13 @@ on:
       - main
     paths:
       - ".github/workflows/ci.yml"
-      - "deployment/*"
+      - "deployment/**"
   pull_request:
     branches:
       - main
     paths:
       - ".github/workflows/ci.yml"
-      - "deployment/*"
+      - "deployment/**"
   workflow_dispatch:
 
 jobs:
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index b025d51..c3346f4 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -83,13 +83,4 @@ jobs:
               }
             } catch (e) {
               console.log(e.status);
-            } finally {
-              for (let file of await fs.readdir('./deployment')) {
-                await github.rest.repos.uploadReleaseAsset({
-                  owner, repo,
-                  release_id: ${{ steps.release.outputs.result }},
-                  name: file,
-                  data: await fs.readFile(`./deployment/${file}`)
-                })
-              }
             }
diff --git a/deployment/nifi/nifi.yml b/deployment/nifi/nifi.yml
index e329c46..07bd108 100644
--- a/deployment/nifi/nifi.yml
+++ b/deployment/nifi/nifi.yml
@@ -64,7 +64,7 @@ spec:
                 - ALL
       containers:
       - name: nifi
-        image: docker.io/apache/nifi:1.24.0
+        image: docker.io/apache/nifi:1.25.0
         imagePullPolicy: IfNotPresent
         ports:
         - containerPort: 8080
diff --git a/deployment/zookeeper/zookeeper.yml b/deployment/zookeeper/zookeeper.yml
index 1d16b50..75e1df7 100644
--- a/deployment/zookeeper/zookeeper.yml
+++ b/deployment/zookeeper/zookeeper.yml
@@ -34,7 +34,7 @@ spec:
           type: RuntimeDefault
       containers:
       - name: zookeeper
-        image: docker.io/zookeeper:3.8
+        image: docker.io/zookeeper:3.9
         imagePullPolicy: IfNotPresent
         ports:
         - containerPort: 2181