{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":102186072,"defaultBranch":"main","name":"safe-smart-account","ownerLogin":"safe-global","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-09-02T09:23:38.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/102983781?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1727446911.0","currentOid":""},"activityList":{"items":[{"before":"0796a376285ab8faefae847b51ef78e92f4df5d5","after":"3e2ee891c0adb65cec4e2f81782d9f646130c715","ref":"refs/heads/main","pushedAt":"2024-09-27T14:28:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"remedcu","name":"Shebin John","path":"/remedcu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30735581?s=80&v=4"},"commit":{"message":"Remove unused mock contracts from SafeToL2Migration tests (#837)\n\nThis pull request focuses on cleaning up the `SafeToL2Migration.spec.ts`\r\ntest file by removing unused imports and redundant mock setup code.\r\nThese changes streamline the test setup and improve code readability.\r\n\r\nCode cleanup and simplification:\r\n\r\n* Removed the unused `getMock` import from\r\n`test/libraries/SafeToL2Migration.spec.ts`.\r\n* Deleted the setup and usage of `validGuardMock` and `invalidGuardMock`\r\nin the `SafeToL2Migration` library tests, as they were not used in the\r\nactual tests.\r\n[[1]](diffhunk://#diff-75100fb7649ea61385b33880528c60fc7ed991face5d9285fa01ebaeb4616221L79-L86)\r\n[[2]](diffhunk://#diff-75100fb7649ea61385b33880528c60fc7ed991face5d9285fa01ebaeb4616221L116-L117)","shortMessageHtmlLink":"Remove unused mock contracts from SafeToL2Migration tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2553070158\" data-permission-text=\"Title is private\" data-url=\"https://github.com/safe-global/safe-smart-account/issues/837\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/safe-global/safe-smart-account/pull/837/hovercard\" href=\"https://github.com/safe-global/safe-smart-account/pull/837\">#837</a>)"}},{"before":null,"after":"883c0fb0289ff1bffd84cbe9aaa241ded5b21ae5","ref":"refs/heads/remove-unused-test-contracts","pushedAt":"2024-09-27T14:21:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"Remove unused mock contracts from SafeToL2Migration spec","shortMessageHtmlLink":"Remove unused mock contracts from SafeToL2Migration spec"}},{"before":"1c70d4944fced9cc43f3e75f7ee26292aa4d4f85","after":"e603bfa3d109b7313a53609aba443e0a2a2e98ef","ref":"refs/heads/v1.4.1/zksync-compat","pushedAt":"2024-09-27T14:17:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"748a34e4026ac367c46fc78b1a142fae3a1daf90","after":"1c70d4944fced9cc43f3e75f7ee26292aa4d4f85","ref":"refs/heads/v1.4.1/zksync-compat","pushedAt":"2024-09-27T13:39:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"6a54289e2398264c61e92b0dc6000e8fec0d9e16","after":null,"ref":"refs/heads/test-workflow","pushedAt":"2024-09-27T09:41:20.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"}},{"before":"73b177851f19725892820ab2687704bfcda6b676","after":"0796a376285ab8faefae847b51ef78e92f4df5d5","ref":"refs/heads/main","pushedAt":"2024-09-27T09:39:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"remedcu","name":"Shebin John","path":"/remedcu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30735581?s=80&v=4"},"commit":{"message":"Tests job updated in Workflow (#836)\n\nPreviously we only checked coverage using `npm run coverage` which I\r\nbelieve only checked `hardhat test --network hardhat`, thus not checking\r\nthe rest of the types of test based on L1, L2 and ZK. This adds another\r\njob in the CI which checks for the same.","shortMessageHtmlLink":"Tests job updated in Workflow (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2552426178\" data-permission-text=\"Title is private\" data-url=\"https://github.com/safe-global/safe-smart-account/issues/836\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/safe-global/safe-smart-account/pull/836/hovercard\" href=\"https://github.com/safe-global/safe-smart-account/pull/836\">#836</a>)"}},{"before":"90bba3eae33835ccc702dc14b03ce96058d2f880","after":"6a54289e2398264c61e92b0dc6000e8fec0d9e16","ref":"refs/heads/test-workflow","pushedAt":"2024-09-27T09:18:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"remedcu","name":"Shebin John","path":"/remedcu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30735581?s=80&v=4"},"commit":{"message":"Remove matrix","shortMessageHtmlLink":"Remove matrix"}},{"before":null,"after":"90bba3eae33835ccc702dc14b03ce96058d2f880","ref":"refs/heads/test-workflow","pushedAt":"2024-09-27T09:11:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"remedcu","name":"Shebin John","path":"/remedcu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30735581?s=80&v=4"},"commit":{"message":"Tests command updated","shortMessageHtmlLink":"Tests command updated"}},{"before":"47bb7641fb5d9a34dcb64ad94777a0445118fa39","after":"748a34e4026ac367c46fc78b1a142fae3a1daf90","ref":"refs/heads/v1.4.1/zksync-compat","pushedAt":"2024-09-27T09:00:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"c9492fb1d9a365e81f2526a598663acf62b857b4","after":"47bb7641fb5d9a34dcb64ad94777a0445118fa39","ref":"refs/heads/v1.4.1/zksync-compat","pushedAt":"2024-09-26T15:41:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"1d524c23f64be3bb3a2970238f5ba0728d7cbf1d","after":"c9492fb1d9a365e81f2526a598663acf62b857b4","ref":"refs/heads/v1.4.1/zksync-compat","pushedAt":"2024-09-26T15:03:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"492d86626eac37137592fce5e6b88eedf03a35f8","after":"1d524c23f64be3bb3a2970238f5ba0728d7cbf1d","ref":"refs/heads/v1.4.1/zksync-compat","pushedAt":"2024-09-26T14:35:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"1cec0e7a6e740c72bbe566ee4f497c9ddc71a6ae","after":"73b177851f19725892820ab2687704bfcda6b676","ref":"refs/heads/main","pushedAt":"2024-09-26T14:34:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"fix: remove deprecated `husky install` command (#835)\n\nThis branch:\r\n\r\n- [x] fix two function state mutability\r\n- [x] fix husky deprecated command","shortMessageHtmlLink":"fix: remove deprecated <code>husky install</code> command (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2549778824\" data-permission-text=\"Title is private\" data-url=\"https://github.com/safe-global/safe-smart-account/issues/835\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/safe-global/safe-smart-account/pull/835/hovercard\" href=\"https://github.com/safe-global/safe-smart-account/pull/835\">#835</a>)"}},{"before":"3375920689e86251bff7e11cb9ef97376311607b","after":"492d86626eac37137592fce5e6b88eedf03a35f8","ref":"refs/heads/v1.4.1/zksync-compat","pushedAt":"2024-09-26T14:23:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"10584fadf4d14006c5ddb59fb68ccda19abfe476","after":"b71a274be83ab4cffa615f7217fd41ba385677c6","ref":"refs/heads/cla-signatures","pushedAt":"2024-09-26T07:48:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"@toolabi has signed the CLA in safe-global/safe-smart-account#835","shortMessageHtmlLink":"<a class=\"user-mention notranslate\" data-hovercard-type=\"user\" data-hovercard-url=\"/users/toolabi/hovercard\" data-octo-click=\"hovercard-link-click\" data-octo-dimensions=\"link_type:self\" href=\"https://github.com/toolabi\">@toolabi</a> has signed the CLA in <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2549778824\" data-permission-text=\"Title is private\" data-url=\"https://github.com/safe-global/safe-smart-account/issues/835\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/safe-global/safe-smart-account/pull/835/hovercard\" href=\"https://github.com/safe-global/safe-smart-account/pull/835\">#835</a>"}},{"before":"45821ac9e293801c57eb9e0a69e2a55beb555b1c","after":null,"ref":"refs/heads/safeToL2Migration-zksync","pushedAt":"2024-09-20T09:52:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"}},{"before":"70673bb860199db7737d1194fc39a16e6f9bbd9a","after":"1cec0e7a6e740c72bbe566ee4f497c9ddc71a6ae","ref":"refs/heads/main","pushedAt":"2024-09-20T09:52:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"Add zkSync support to `SafeToL2Migration` tests  (#834)\n\nThis PR:\r\n- Almost Implements #767 by applying the same principles to\r\nSafeToL2Migration tests as in\r\nhttps://github.com/safe-global/safe-smart-account/pull/833\r\n- I will cherry-pick the changes back to 1.4.1 branch once the hardhat\r\ncompiler plugin issue is addressed","shortMessageHtmlLink":"Add zkSync support to <code>SafeToL2Migration</code> tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2537066626\" data-permission-text=\"Title is private\" data-url=\"https://github.com/safe-global/safe-smart-account/issues/834\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/safe-global/safe-smart-account/pull/834/hovercard\" href=\"https://github.com/safe-global/safe-smart-account/pull/834\">#834</a>)"}},{"before":"b5e785e4995334e2c2cc955ccc38c78eaf6d1418","after":"45821ac9e293801c57eb9e0a69e2a55beb555b1c","ref":"refs/heads/safeToL2Migration-zksync","pushedAt":"2024-09-19T18:26:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"SafeToL2Migration tests","shortMessageHtmlLink":"SafeToL2Migration tests"}},{"before":"14958349a38046f53055c176dae92204e2769de4","after":"b5e785e4995334e2c2cc955ccc38c78eaf6d1418","ref":"refs/heads/safeToL2Migration-zksync","pushedAt":"2024-09-19T18:18:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"SafeToL2Migration tests","shortMessageHtmlLink":"SafeToL2Migration tests"}},{"before":"72ebb905b4229ee28091c86095b55e655dad5d0c","after":"14958349a38046f53055c176dae92204e2769de4","ref":"refs/heads/safeToL2Migration-zksync","pushedAt":"2024-09-19T18:10:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"SafeToL2Migration tests","shortMessageHtmlLink":"SafeToL2Migration tests"}},{"before":"2fce2368801755963145f8c50357e4d34735a1f1","after":"72ebb905b4229ee28091c86095b55e655dad5d0c","ref":"refs/heads/safeToL2Migration-zksync","pushedAt":"2024-09-19T17:52:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"pull from dev","shortMessageHtmlLink":"pull from dev"}},{"before":"d4cc90cc4ee0767c447696cff187737f2ed315fe","after":null,"ref":"refs/heads/migration-tests-zksync","pushedAt":"2024-09-19T17:19:43.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"}},{"before":"7ccf6e00bab3e1034325a7fd06a346caed22aefb","after":"70673bb860199db7737d1194fc39a16e6f9bbd9a","ref":"refs/heads/main","pushedAt":"2024-09-19T17:19:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"Update `SafeMigration` tests for zkSync (#833)\n\nThis PR:\r\n- Partially solves\r\nhttps://github.com/safe-global/safe-smart-account/issues/767 (test\r\nupdates for `SafeToL2Upgrade` are still pending)\r\n- It is based on version 1.5.0 because 1.4.1 cannot be compiled at the\r\nmoment because we used `.send` in there, and hardhat zksync compiler\r\nplugin needs to be updated to support suppressing errors. I will\r\ncherry-pick it later.\r\n- I updated the `deployContract` function name and return type to be\r\nmore self-explanatory\r\n- The main changes were around adding zksync compatible bytecode and\r\nalso using the ContractFactory from the \"zksync-ethers\" package because\r\nin ZkSync you need to interact with a system contract to deploy\r\ncontracts and not just send a transaction with the bytecode and\r\n`to` address omitted.\r\n\r\nOne bug found: https://github.com/matter-labs/hardhat-zksync/issues/1420","shortMessageHtmlLink":"Update <code>SafeMigration</code> tests for zkSync (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2533582418\" data-permission-text=\"Title is private\" data-url=\"https://github.com/safe-global/safe-smart-account/issues/833\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/safe-global/safe-smart-account/pull/833/hovercard\" href=\"https://github.com/safe-global/safe-smart-account/pull/833\">#833</a>)"}},{"before":"1efa972793757cad0f07c4f01761cc65d8a49ced","after":"d4cc90cc4ee0767c447696cff187737f2ed315fe","ref":"refs/heads/migration-tests-zksync","pushedAt":"2024-09-19T17:07:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"Update zksync package and remove the util function","shortMessageHtmlLink":"Update zksync package and remove the util function"}},{"before":"817ce4ba47e6f60c20ec57a8116730cf533e4909","after":"2fce2368801755963145f8c50357e4d34735a1f1","ref":"refs/heads/safeToL2Migration-zksync","pushedAt":"2024-09-19T16:52:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"SafeToL2Migration tests","shortMessageHtmlLink":"SafeToL2Migration tests"}},{"before":null,"after":"817ce4ba47e6f60c20ec57a8116730cf533e4909","ref":"refs/heads/safeToL2Migration-zksync","pushedAt":"2024-09-19T10:20:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"SafeToL2Migration tests","shortMessageHtmlLink":"SafeToL2Migration tests"}},{"before":"b4c734fe9b21b9e0706c3841616fb02efebbc335","after":"1efa972793757cad0f07c4f01761cc65d8a49ced","ref":"refs/heads/migration-tests-zksync","pushedAt":"2024-09-18T11:57:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"support zksync in migration tests","shortMessageHtmlLink":"support zksync in migration tests"}},{"before":"7975f52b8f6513a2aa86ce408ad88f7365e7bf71","after":"b4c734fe9b21b9e0706c3841616fb02efebbc335","ref":"refs/heads/migration-tests-zksync","pushedAt":"2024-09-18T10:55:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"support zksync in migration tests","shortMessageHtmlLink":"support zksync in migration tests"}},{"before":"dcc17c33a42aaca00b0e729e416041aca0f7f5f9","after":"7975f52b8f6513a2aa86ce408ad88f7365e7bf71","ref":"refs/heads/migration-tests-zksync","pushedAt":"2024-09-18T10:46:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"support zksync in migration tests","shortMessageHtmlLink":"support zksync in migration tests"}},{"before":"fddfd1478471b92c90f9f2ad38be3a531c908135","after":"7ccf6e00bab3e1034325a7fd06a346caed22aefb","ref":"refs/heads/main","pushedAt":"2024-09-18T10:42:38.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mmv08","name":"Mikhail","path":"/mmv08","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16622558?s=80&v=4"},"commit":{"message":"Docs: Update README (#831)\n\nCo-authored-by: Mikhail <16622558+mmv08@users.noreply.github.com>\r\nCo-authored-by: Nicholas Rodrigues Lordello <n@lordello.net>","shortMessageHtmlLink":"Docs: Update README (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2526114567\" data-permission-text=\"Title is private\" data-url=\"https://github.com/safe-global/safe-smart-account/issues/831\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/safe-global/safe-smart-account/pull/831/hovercard\" href=\"https://github.com/safe-global/safe-smart-account/pull/831\">#831</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yN1QxNDoyODo1My4wMDAwMDBazwAAAATCs7NQ","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xOFQxMDo0MjozOC4wMDAwMDBazwAAAAS5jSXc"}},"title":"Activity · safe-global/safe-smart-account"}