Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code cleanup and improvements #977

Merged
merged 17 commits into from
Sep 25, 2024
Merged

chore: code cleanup and improvements #977

merged 17 commits into from
Sep 25, 2024

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Sep 18, 2024

What it solves

Resolves #

How this PR fixes it

@dasanra dasanra changed the base branch from main to development September 18, 2024 10:54
@coveralls
Copy link

coveralls commented Sep 18, 2024

Pull Request Test Coverage Report for Build 11029510443

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.73%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/sdk-starter-kit/src/extensions/messages/onChainMessages.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 11029492105: 0.0%
Covered Lines: 777
Relevant Lines: 948

💛 - Coveralls

@dasanra dasanra marked this pull request as ready for review September 25, 2024 08:56
@dasanra dasanra changed the title chore: improvements chore: code cleanup and improvements Sep 25, 2024
@dasanra dasanra merged commit 2f60640 into development Sep 25, 2024
20 checks passed
@dasanra dasanra deleted the sdk-improvements branch September 25, 2024 09:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants