Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to safe-deployments 1.24 #465

Merged
merged 5 commits into from
Jun 23, 2023
Merged

chore: Update to safe-deployments 1.24 #465

merged 5 commits into from
Jun 23, 2023

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Jun 23, 2023 •
edited
Loading

What it solves

Resolves #

  • Adds missing networks reported by yarn build
  • update packages dependency safe-deployment to 1.24.0

How this PR fixes it

@github-actions
Copy link

github-actions bot commented Jun 23, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@octavioamu
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@octavioamu
Copy link
Contributor Author

recheck

@octavioamu
Copy link
Contributor Author

bot is failing seems but job succeed https://github.com/safe-global/safe-core-sdk/actions/runs/5358776194/jobs/9721523426

germartinez
germartinez suggested changes Jun 23, 2023
View reviewed changes
packages/protocol-kit/package.json Outdated Show resolved Hide resolved
packages/safe-ethers-adapters/package.json Outdated Show resolved Hide resolved
@octavioamu octavioamu changed the title feat: Update to safe-deployments 1.23 feat: Update to safe-deployments 1.24 Jun 23, 2023
@germartinez
Copy link
Member

germartinez commented Jun 23, 2023 •
edited
Loading

Could you please also update the safe-deployments dependency in ‎

safe-core-sdk/packages/safe-core-sdk-types/package.json

Line 34 in 163f58b

"@safe-global/safe-deployments": "^1.22.0",
and

safe-core-sdk/packages/safe-ethers-adapters/package.json

Line 61 in 163f58b

"@safe-global/safe-deployments": "^1.22.0",
?

@germartinez germartinez changed the title feat: Update to safe-deployments 1.24 chore: Update to safe-deployments 1.24 Jun 23, 2023
@octavioamu
Copy link
Contributor Author

octavioamu commented Jun 23, 2023 •
edited
Loading

@germartinez humm seems that is not my change? or Im missing something
Here are the link diff with those changes done

https://github.com/safe-global/safe-core-sdk/pull/465/files#diff-af3d0af9ead5aed634e24847d6036615c478556fb502d5a1b63ce87c25df7ff3L34
https://github.com/safe-global/safe-core-sdk/pull/465/files#diff-1bbab147139af53210a4830f31d14a115c2254716ebe9919f22ad526ef572b7bL61

@germartinez
Copy link
Member

Completely true! Sorry for that :)

Thank you for this PR. Approving it now

@germartinez germartinez self-requested a review June 23, 2023 17:50
@germartinez germartinez merged commit cf136a0 into safe-global:main Jun 23, 2023
2 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germartinez germartinez germartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@octavioamu @germartinez