From e753a40b435f5c101d40fe26827655bd06ee8d41 Mon Sep 17 00:00:00 2001 From: Nishant Samel Date: Mon, 1 Jul 2024 13:32:28 +0530 Subject: [PATCH] Fix `invoices` factory to avoid flakyness --- spec/factories/invoices.rb | 2 +- spec/system/invoices/invoice_history_spec.rb | 2 +- spec/system/invoices/send_invoice_spec.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/factories/invoices.rb b/spec/factories/invoices.rb index da757bdb22..4c9b7c8932 100644 --- a/spec/factories/invoices.rb +++ b/spec/factories/invoices.rb @@ -14,7 +14,7 @@ # amount_paid { Faker::Number.decimal(r_digits: 2) } # amount_due { Faker::Number.decimal(r_digits: 2) } # discount { Faker::Number.decimal(r_digits: 2) } - status { [:draft, :paid, :overdue].sample } + status { :draft } external_view_key { "#{SecureRandom.hex}" } factory :invoice_with_invoice_line_items do transient do diff --git a/spec/system/invoices/invoice_history_spec.rb b/spec/system/invoices/invoice_history_spec.rb index 0858304396..7b6dc73a8c 100644 --- a/spec/system/invoices/invoice_history_spec.rb +++ b/spec/system/invoices/invoice_history_spec.rb @@ -3,7 +3,7 @@ require "rails_helper" RSpec.describe "View Invoice Logs", type: :system do - let!(:invoice) { create :invoice_with_invoice_line_items, status: :draft } + let!(:invoice) { create :invoice_with_invoice_line_items } let(:client) { invoice.client } let!(:company) { invoice.company } let(:admin) { create(:user, current_workspace_id: company.id) } diff --git a/spec/system/invoices/send_invoice_spec.rb b/spec/system/invoices/send_invoice_spec.rb index c847cb22ea..035e7f95bc 100644 --- a/spec/system/invoices/send_invoice_spec.rb +++ b/spec/system/invoices/send_invoice_spec.rb @@ -3,7 +3,7 @@ require "rails_helper" RSpec.describe "Send Invoice", type: :system do - let(:invoice) { create :invoice_with_invoice_line_items, status: :draft } + let(:invoice) { create :invoice_with_invoice_line_items } let(:client) { invoice.client } let(:company) { invoice.company } let(:admin) { create(:user, current_workspace_id: company.id) }