Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can rxmq support angular 8.x? #28

Open
dyh333 opened this issue Jul 15, 2019 · 4 comments
Open

can rxmq support angular 8.x? #28

dyh333 opened this issue Jul 15, 2019 · 4 comments

Comments

@dyh333
Copy link

dyh333 commented Jul 15, 2019

I had update angular to v8.1, but found rxmq not work yet.
image

@yamalight
Copy link
Contributor

@dyh333 Angular itself shouldn't matter to rxmq 🤔
which version of RxJS are you using?

@dyh333
Copy link
Author

dyh333 commented Jul 16, 2019

@yamalight . sorry, I means ng8 need rxjs version ~6.4.0. and I install rxjs v6.4.0 , rxmq v1.2.2

@dyh333
Copy link
Author

dyh333 commented Jul 16, 2019

@yamalight hi, I had found problem. angular v8 has a new feature:

The CLI's build command now automatically creates a modern ES2015 build with minimal polyfills and a compatible ES5 build for older browsers, and loads the appropriate file based on the browser. You may opt-out of this change by setting your target back to es5 in your tsconfig.json. Learn more on angular.io.

it means that in tsconfig, the default target is 'es2015', but rxmq build dist is es5 yet. so cause the bug above.
I change target to es5, rxmq will work well. but the method would not use the new feature of ng.
if rxmq could support both es5 and es2015(es6), that would be better.

thanks

@yamalight
Copy link
Contributor

@dyh333 I haven't worked with Angular since v1.x so wouldn't know where to even start with this, but I would be more than happy to accept a PR that adds this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants