Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown comments in the template break config parsing #19

Closed
jcgruenhage opened this issue Aug 14, 2020 · 2 comments
Closed

Markdown comments in the template break config parsing #19

jcgruenhage opened this issue Aug 14, 2020 · 2 comments

Comments

@jcgruenhage
Copy link
Contributor

Markdown comments inside the template break the parsing of the config inside the changelog. The fix to this is counting opening/closing comment markers and only reading the config after the outermost opening comment marker has been closed (or rather, the outermost closing comment marker has been opened, considering the CHANGELOG is read in reverse order.
@jcgruenhage
Copy link
Contributor Author

(The problem described in #15 is caused by this most likely btw)

@JeanMertz
Copy link
Member

Thanks for the detailed report. I'm tracking this in #14. I'll close this one, and hopefully have a fix ready sometime tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeanMertz @jcgruenhage