Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint integration #10

Open
vitvakatu opened this issue Jun 14, 2017 · 4 comments
Open

Mint integration #10

vitvakatu opened this issue Jun 14, 2017 · 4 comments

Comments

@vitvakatu
Copy link
Contributor

https://github.com/kvark/mint

@torkleyy
Copy link
Member

While this is strictly speaking against the statement of the README:

This library is an extension of cgmath that provides collision detection primitives.

I approve the idea 👍

@vitvakatu
Copy link
Contributor Author

Actually, I'm not going to strictly follow the way of original library. Situation in gamedev sphere changed a lot, I'm planning to follow the currents.
I hope cgmath will include mint soon and I wish mint be the de-facto standard wrapper for every math lib.

@trsoluti
Copy link
Contributor

I took a look at this and created a huge mud-pile in my GitHub folder (the mint-integration branch). It will take some time to convert, as collision is a rich interface, but I definitely think it's a good idea. Traits that are needed to implement collision with cgmath should be private, and only basic traits like those from num-traits and mint should be public. It will certainly help reduce the log driver's waltz that most dependent library-writers have to do.

@eadf
Copy link
Contributor

eadf commented Sep 22, 2021

Now that you are using cgmath 0.18, isn't this a one-line fix?
Cargo.toml:

...
[features]
serde = ["serde_crate", "cgmath/serde", "num/serde"]
mint = ["cgmath/mint"] <----
...

Could even add the other cgmath supported features as well (rand,swizzle,unstable)

But this is quite redundant. All this does is to enable the feature in the cgmath crate, something that should already be done in the end-user toml (as long as the versions match).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants