Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soft errors to minidump #31

Open
Jake-Shadle opened this issue May 25, 2022 · 1 comment · May be fixed by #138
Open

Add soft errors to minidump #31

Jake-Shadle opened this issue May 25, 2022 · 1 comment · May be fixed by #138

Comments

@Jake-Shadle
Copy link
Collaborator

We've discussed loosening many of the hard failures inherited from Breakpad into more soft errors, as in many cases, even if a piece of process information cannot be retrieved for some reason, the dump will still contain all of the useful information that we did retrieve. For example, if we can't retrieve the name of a thread for some reason, or it isn't utf-8, that should just mean we skip that thread or write an empty or placeholder name for it, but don't fail the entire dump creation.

This however means that when you get a minidump it might be missing information you were expecting. What would be cool is if in these soft errors cases actually recorded the failure, eg "failed to get thread name for thread ", and actually add those failures to a separate minidump stream at the end. This would allow end users to still get the useful information that was retrieved during minidump creation, but also see exactly why there might be various things missing that they might have expected.

@gabrielesvelto
Copy link
Contributor

Adding a datapoint here: most of the times we've seen Firefox fail to generate a minidump it's been for these three reasons (in order of volume):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants