Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble zipping library #53

Open
arnemileswinter opened this issue Oct 22, 2022 · 1 comment
Open

Trouble zipping library #53

arnemileswinter opened this issue Oct 22, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@arnemileswinter
Copy link

Hey, cool action. It gets right to the point!

I am facing issues building a library and uploading an artifact for it. namely a "cdylib". Does this only work with executables?

The build step fails with:

::info::Packing files: 

zip error: Nothing to do! (tmp.zip)

my workflow is this: https://github.com/arnemileswinter/godot-tilemap-flowfields/blob/13323a86258b3e3063c1045171af212ed08fcb57/.github/workflows/build.yml

Thanks for the help!

@Douile
Copy link
Member

Douile commented Oct 24, 2022

Yes, we only check for binaries.

https://github.com/rust-build/rust-build.action/blob/master/build.sh#L81

A workaround would be a custom build script that outputs the name of the library, but it would be nice if we add that support.

@Douile Douile added the enhancement New feature or request label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants