Cargo build fails

[kcalvinalvin]

Just git cloning the master branch and cargo build is failing.

log:

[I] > cargo build
   Compiling hammersbald v2.4.0
error[E0603]: module `export` is private
   --> /home/calvin/.cargo/registry/src/github.com-1ecc6299db9ec823/hammersbald-2.4.0/src/bitcoin_adaptor.rs:34:12
    |
34  | use serde::export::PhantomData;
    |            ^^^^^^ private module
    |
note: the module `export` is defined here
   --> /home/calvin/.cargo/registry/src/github.com-1ecc6299db9ec823/serde-1.0.123/src/lib.rs:275:5
    |
275 | use self::__private as export;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0603`.
error: could not compile `hammersbald`

To learn more, run the command again with --verbose.

[sgeisler]

Murmel isn't that well maintained. The error you see is clearly a mishap in hammersbald (probably by IntelliJ Rust, which can auto-import stuff and accidentally took PhantomData from serde::export instead of std::markers). I guess a recent serde update fixed the std re-export and broke the build that way.

Version 3 of hammersbald already has a fix for it (relevant commit). You could try to migrate murmel to the new hammersbald version or just fix the import and use your patched version locally.

[stevenroose]

#47 fixes this issue, @kcalvinalvin could you verify that it works for you?

[kcalvinalvin]

#47 fixes this issue, @kcalvinalvin could you verify that it works for you?

Yes it works for me on commit hash 8b93a33884956970c8c87bde2d00c934d8bca440

[chrisguida]

Can confirm that master was broken as described above, and #47 fixes it