-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace progress dots with <sl-progress-bar>
#51
Comments
That's a great feature, I love it. I'm not sure if it should be composeable
(i.e. something you slot into the deck) or if it should be embedded inside
the deck. I wouldn't mind either way I think.
I think the minimum requirements would be being able to configure the
height and colour (with opacity) at the deck level, and have a way to hide
the progress bar as an option on individual slides. And obviously it should
be an opt-in feature that's set at the deck level.
…On Tue, Jun 20, 2023, 12:09 Benny Powers ***@***.***> wrote:
https://shoelace.style/components/progress-bar
see https://bennypowers.dev/decks/devconf-brno-2023 for an example
—
Reply to this email directly, view it on GitHub
<#51>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAQJSRSY2NMVVMQLDBJ4KDXMFZHHANCNFSM6AAAAAAZNBM2S4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
height, color, opacity, etc are all configurable with css hiding on individual slides could likewise be with some javascript, or perhaps by reflecting the slide number/name to the deck element |
I think the deck can handle most of these things. It can know the total
number of steps and the current step. It can also check the active slide if
the progress bar should be hidden. If it's composed, it can control the
slotted progress bar and feed it the right state.
The difficult part is that we have to align on a single interface for the
slotted progress bar. I.e. it needs some standard method to set the total
number of steps, and the current step. So not all custom progress bars will
work by default, they would have to adhere to this interface. But it would
probably be trivial to write a wrapper for any progress bar that does that
…On Tue, Jun 20, 2023, 12:35 Benny Powers ***@***.***> wrote:
height, color, opacity, etc are all configurable with css
html composability is easy with slot default content, the js apis are a
little trickier, so users that slot in their own progress would need to
write their own event listener
hiding on individual slides could likewise be with some javascript, or
perhaps by reflecting the slide number/name to the deck element
—
Reply to this email directly, view it on GitHub
<#51 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAQJSVETHZODUPCA65SMMLXMF4FZANCNFSM6AAAAAAZNBM2S4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://shoelace.style/components/progress-bar
see https://bennypowers.dev/decks/devconf-brno-2023 for an example
The text was updated successfully, but these errors were encountered: