Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor previousValue tracking in NodePart #3

Open
ruphin opened this issue Aug 5, 2018 · 0 comments
Open

Refactor previousValue tracking in NodePart #3

ruphin opened this issue Aug 5, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@ruphin
Copy link
Owner

ruphin commented Aug 5, 2018

Currently previousValue is used in the individual _render helpers, but set globally in the render function. It doesn't work as intended for _renderPrimitive, and there are some other issues. It would also be nice if render itself could exit early if it detects no value change.

Probably the way to go is checking for TemplateResult and Iterable first, then having a single guard for value === previousValue for the other render types. The main complexity is figuring out a correct solution for _renderPromise.

@ruphin ruphin added the enhancement New feature or request label Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant