Add platforms to lockfile to lock platform-specific gems #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Giddins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5075 +/- ##
=======================================
Coverage 97.03% 97.03%
=======================================
Files 421 421
Lines 8776 8776
=======================================
Hits 8516 8516
Misses 260 260 ☔ View full report in Codecov by Sentry. |
colby-swandale
approved these changes
Sep 26, 2024
deivid-rodriguez
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Yes! We will be warning about this with rubygems/rubygems#8029, so this is fixing the warning before it shows up :)
segiddins
deleted the
segiddins/add-platforms-to-lockfile-to-lock-platform-specific-gems
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samuel Giddins [email protected]