Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event Handler missing on flow and minicharts object. #17

Open
moonbrandy opened this issue Jul 5, 2017 · 4 comments
Open

event Handler missing on flow and minicharts object. #17

moonbrandy opened this issue Jul 5, 2017 · 4 comments

Comments

@moonbrandy
Copy link

The flow and minicharts object should be at the same level shape or marker in leaflet, therefore, each individual object should be able to assign an layerID instead of the whole layer is just one big object with one ID. I hope this feedback is somehow useful. I'm working on this change, do let me know if you guys want a copy of it. Keep up the great work. The package looks good.

@FrancoisGuillem
Copy link
Contributor

Hello. I'm not sure I have understood your issue. Could you describe a use case with the actual behavior and the expected one? Anyway, feel free to share your work by doing a pull request.

@moonbrandy
Copy link
Author

Hi Francois,

The problem I'm facing is the minicharts been added to leaflet as minicharts object instead of inherent from a shape or marker from leaflet. The reason why I would hope that's an inherent is because it will have the interface with shiny so that I can get what has been clicked by just call input$mapid_shape_click in the shiny side. With these event handler I can do advanced interaction in shiny's back end. I hope that clears a bit confusion.

Regards,
Danny

@FrancoisGuillem
Copy link
Contributor

Ok I understand now. This would be a very intersting feature indeed!

@paragemini
Copy link

Has this feature been implemented ? can minicharts be selected (appear) and de-selected (disappear) from the map using layers in leaflet ? I would be grateful if this feature can be implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants