Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shiny Event classes for custom events #3815

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Commits on Apr 27, 2023

  1. Configuration menu
    Copy the full SHA
    01fd8fa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    90c0523 View commit details
    Browse the repository at this point in the history
  3. Remove value, add el to ShinyEventInputChanged

    Also mark `priority` as optional since it was optionally provided in practice
    gadenbuie committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    8d12ae7 View commit details
    Browse the repository at this point in the history
  4. Implement EventCommon and EventInputChanged classes

    These classes create the custom Shiny events and help us extend JQuery's event handlers for these event types.
    gadenbuie committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    0e2d040 View commit details
    Browse the repository at this point in the history
  5. Use EventInputChanged() to emit file upload input event

    We now do this in place rather than as a separate function,
    i.e. we replace `triggerFileInputChanged()` with our improved
    abstraction.
    gadenbuie committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    e2d19b9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    60f074d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    54fa857 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    63427a7 View commit details
    Browse the repository at this point in the history
  9. Implement one lower-level event class EventBase and use event rat…

    …her than `evt`
    
    It turns out the props on EventCommon aren't used everywhere
    gadenbuie committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    651b768 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    922d16d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2740be1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b5c6561 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a66ef6d View commit details
    Browse the repository at this point in the history
  14. Use @babel/plugin-transform-typescript

    It was already used by preset-typescript, but we need to use the
    plugin so that the transpilation happens at the right time, in
    particular because we are using `declare` within classes.
    gadenbuie committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    08ced6b View commit details
    Browse the repository at this point in the history
  15. import $ from jquery

    gadenbuie committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    4f50796 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    ce4961f View commit details
    Browse the repository at this point in the history
  17. DRY properties and type definitions

    * Use getters to expose data from `this.event` as if they were top-level
    * Refer to the interfaces directly rather than repeating type definitions
    gadenbuie committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    0adeb4b View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    4648423 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    eddb0d9 View commit details
    Browse the repository at this point in the history
  20. yarn build

    gadenbuie committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    064da3a View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Configuration menu
    Copy the full SHA
    10c2398 View commit details
    Browse the repository at this point in the history