Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce support for supports_fetch_first_n_rows_and_offset? functionality #2395

Open
yahonda opened this issue Sep 22, 2024 · 0 comments

Comments

@yahonda
Copy link
Collaborator

yahonda commented Sep 22, 2024

Steps to reproduce

def supports_fetch_first_n_rows_and_offset?
false
# TODO: At this point the connection is not initialized yet,
# so `database_version` raises an error
#
# !use_old_oracle_visitor && database_version.first >= 12
end

Expected behavior

supports_fetch_first_n_rows_and_offset? should consider use_old_oracle_visitor and database_version

Actual behavior

It always returns false

System configuration

Rails version: 7.1.4

Oracle enhanced adapter version: master branch

Ruby version: ruby 3.3.5 (2024-09-03 revision ef084cc8f4) [x86_64-linux]

Oracle Database version: Oracle Database 23ai Free Release 23.0.0.0.0 - Develop, Learn, and Run for Free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant