snapshot is produced with non-unique IDs #76
Comments
|
Is this happening when you snapshot a page more than once? |
|
No, it isn't happening when requesting a page snapshot more than once. I was able to identify that for some websites the assignment So if you create a snapshot for a page and then refresh it, you'll be able to see that, for instance, Unfortunately, I don't have any strong case to share. However, I've noticed that this issue is happening more often in Safari than in any other browser (probably only in Safari). I was able to fix it by collecting the serialized objects into a In a separate file: export const serializedCache = new WeakMap<Node, serializedNodeWithId>();Restoring cache: let serializedNode = serializedCache.get(node);
// Try to reuse the previous id
if (serializedNode) {
id = serializedNode.id;
}Caching a serialized node: const serializedNode = Object.assign(_serializedNode, { id });
serializedCache.set(n, serializedNode);I can create a PR if you approve this modification. |
In some cases calling
snapshot(document)produces a tree with elements which IDs are not unique. In most cases these elements are the root elementdocumentand the first element from<head>e.g.<link>or<style>.It leads to the situation where in
Playerthe root elementdocumentwithid = 1is overwritten by some child node, that also hasid = 1. In this caseIncrementalSource.Event, which is fired fordocument, won't be correctly processed by thePlayerinstance.Here the assignment of non-unique IDs happen:
https://github.com/rrweb-io/rrweb-snapshot/blob/master/src/snapshot.ts#L693
The text was updated successfully, but these errors were encountered: